-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go 1.13 Meta-Issue #590
Comments
/kind feature /good-first-issue (the script stuff is a good first issue, a few of the other items are help-wanted -- feel free to ask if you're not sure) |
@DirectXMan12: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@DirectXMan12: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-soon |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Is it still open as |
I think the last bits of the script cleanup are good-first-issue. The rest is probably requires a bit of thinking through. If you're comfortable putting together a plan, etc, then go ahead and take any of the other bullet points as well. |
#590 - Update documentation for Finalizers to return an explicit error
/assign |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/close |
@vincepri: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Go 1.13 is out 🎉 !
Things we can now do:
Things we can do now-ish
For everything below, we'll need to figure out a potential impact of aggressively switching to Go 1.13 as the min-supported-go-version. I expect Kubernetes will soon-ish, so it might not be that bad for us to do so now. That being said, it's almost certainly a breaking change.
%w
instead of%v
inErrorf
apierrors.IsXYZ
) -- will be aGO111MODULE=on
from our scripts?The text was updated successfully, but these errors were encountered: