Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.13 Meta-Issue #590

Closed
3 of 8 tasks
DirectXMan12 opened this issue Sep 9, 2019 · 13 comments
Closed
3 of 8 tasks

Go 1.13 Meta-Issue #590

DirectXMan12 opened this issue Sep 9, 2019 · 13 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Sep 9, 2019

Go 1.13 is out 🎉 !

Things we can now do:

Things we can do now-ish

For everything below, we'll need to figure out a potential impact of aggressively switching to Go 1.13 as the min-supported-go-version. I expect Kubernetes will soon-ish, so it might not be that bad for us to do so now. That being said, it's almost certainly a breaking change.

  • switch go.mod over to go1.13, so we can use new features
  • Prune any uses of xerrors
  • Figure out where we want to use %w instead of %v in Errorf
  • Figure out if there are spots where we wanted to use wrapping errors but couldn't, and come up with a plan for switching over (relatedly, provide transition plans for folks using apierrors.IsXYZ) -- will be a ⚠️ breaking change
  • revive the structured errors code/figure out what we want to do with that
  • figure out if we want to prune uses of GO111MODULE=on from our scripts?
@DirectXMan12
Copy link
Contributor Author

/kind feature
/priority important soon

/good-first-issue

(the script stuff is a good first issue, a few of the other items are help-wanted -- feel free to ask if you're not sure)

@k8s-ci-robot
Copy link
Contributor

@DirectXMan12:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind feature
/priority important soon

/good-first-issue

(the script stuff is a good first issue, a few of the other items are help-wanted -- feel free to ask if you're not sure)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@DirectXMan12: The label(s) priority/important, priority/soon cannot be appled. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/kind feature
/priority important soon

/good-first-issue

(the script stuff is a good first issue, a few of the other items are help-wanted -- feel free to ask if you're not sure)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 9, 2019
@DirectXMan12
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 16, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2019
@DirectXMan12
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2020
@vnzongzna
Copy link

Is it still open as good-first-issue? If so I would like to learn & work on it :)
The script clean-up is merged, except for the GO111MODULE=on part.

@DirectXMan12
Copy link
Contributor Author

I think the last bits of the script cleanup are good-first-issue. The rest is probably requires a bit of thinking through. If you're comfortable putting together a plan, etc, then go ahead and take any of the other bullet points as well.

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
#590 - Update documentation for Finalizers to return an explicit error
@vincepri vincepri added this to the Next milestone Feb 21, 2020
@vincepri
Copy link
Member

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 29, 2020
@vincepri
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants