Skip to content

🐛 fix: cache should list out of global cache when present and necessary #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

🐛 fix: cache should list out of global cache when present and necessary #3126

merged 1 commit into from
Feb 20, 2025
+9 −6

Conversation

joelanford
Copy link
Member

When the cache options are configured with DefaultNamespaces which include an entry with cache.AllNamespaces, listing from the cache should fallback to the global cache if there are no namespace-specific caches that match the namespace from the list options.

@joelanford
fix: cache should list out of global cache when present and necessary
bfa6d9c 
When the cache options are configured with DefaultNamespaces which
include an entry with `cache.AllNamespaces`, listing from the cache
should fallback to the global cache if there are no namespace-specific
caches that match the namespace from the list options.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2025
@troy0820
Copy link
Member

/lgtm
/hold

In case anyone else wants to review.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c1454f1f125977c106cc0c59b523176be5914316

alvaroaleman
alvaroaleman approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a subtle one, thanks for the fix!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alvaroaleman
Copy link
Member

/hold cancel
/cherrypick release-0.20
/cherrypick release-0.19

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@k8s-infra-cherrypick-robot
Copy link

@alvaroaleman: once the present PR merges, I will cherry-pick it on top of release-0.19, release-0.20 in new PRs and assign them to you.

In response to this:

/hold cancel
/cherrypick release-0.20
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 9024933 into kubernetes-sigs:main Feb 20, 2025
11 of 12 checks passed
@k8s-infra-cherrypick-robot
Copy link

@alvaroaleman: new pull request created: #3127

In response to this:

/hold cancel
/cherrypick release-0.20
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 20, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@alvaroaleman: new pull request created: #3128

In response to this:

/hold cancel
/cherrypick release-0.20
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 20, 2025
Merged
@sbueringer
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees

@troy0820 troy0820

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joelanford @troy0820 @k8s-ci-robot @alvaroaleman @k8s-infra-cherrypick-robot @sbueringer