🐛 Return error if pagination is used with the cached client #3134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/assign @alvaroaleman @vincepri |
|
I can mark the PR as breaking if we want. But if folks were using the usual pattern for pagination before they probably had an endless loop? :) So not sure if we're actually breaking anything here |
sbueringer
changed the title
|
/cc @akutz |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 41d39d3267ffeb483055afe50d90952a551faac7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
Implements option 2 mentioned in #3045
This should make it a lot easier to detect usages of pagination with the cached client (which is not supported)