📖 Docs for SyncPeriod: No sync from api-server.

[guettli]

There is a common misunderstanding about SyncPeriod. It does not sync between api-server and local cache.

This PR updates the docs to make this more clear.

Related: #3269 (comment)

[k8s-ci-robot]

Hi @guettli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alvaroaleman]

I am not a fan of changing this part of the paragaph, because the godoc goes from the big picture to the details/the why to the how, we are now adding parts of the how to the why.

Also it would IMHO be better to explain what does happen, rather than what does not.

WDYT about leaving this part be and changing L176 till the end of the godoc to:

	// SyncPeriod will locally trigger an artificial Update event with the same
	// object in both ObjectOld and ObjectNew for everything that is in the
	// cache.
	//
	// Predicates or Handlers that expect ObjectOld and ObjectNew to be different
	// (such as GenerationChangedPredicate) will filter out this event, preventing
	// it from triggering a reconciliation.

[guettli]

@alvaroaleman Thank you for your feedback. Yes, I am fine with your suggestion. For people like me (who are slow on the uptake), I added a final note stating that there is no sync between the server and the local cache. Is that okay for you now?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, guettli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: cc8dbd69fe315fb4ecd6ee801771147cf3b3c3aa

[sbueringer]

Thank you very much!!
/lgtm