🐛 Disable metrics and health servers during recorder test

[mcristina422]

When running the tests locally the recorder test fails because the metrics server fails to bind to the port. Since the metrics or health server isnt used during this test this PR disables them during the test

STEP: Creating the Manager
2020-04-17T14:11:07.370-0500    INFO    controller-runtime.metrics      metrics server is starting to listen    {"addr": ":8080"}
2020-04-17T14:11:07.385-0500    ERROR   controller-runtime.metrics      metrics server failed to listen. You may want to disable the metrics server or use another port if it is due to conflicts       {"error": "error listening on :8080: listen tcp :8080: bind: address already in use"}

Summarizing 1 Failure:

[Fail] recorder recorder [It] should publish events 
/Users/mcristina444/go/src/github.com/kubernetes-sigs/controller-runtime/pkg/internal/recorder/recorder_integration_test.go:55

[k8s-ci-robot]

Hi @mcristina422. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mcristina422
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mcristina422]

/assign @droot

[mcristina422]

Also found as a failure in the output of #907

[alexeldeib]

/ok-to-test

[alexeldeib]

The tests don't bring up anything multiple things on 8080, do they? I'm fine with disabling regardless, but I wanted to double check the error was from a local process.

/lgtm

thanks!

[mcristina422]

There are multiple integration tests that start managers with open ports. I'm not sure why this one is causing issues, as none of the others ever fail to start this way. I was able to reproduce this a handful of time. This fix definitely worked on my machine though

[alexeldeib]

That sounds potentially race-y, we may want to make that more deterministic (or more random I guess)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.