Merge pull request #573 from kmodules/imprv-err-msg

🏃 Improve error message for list or map type
kubernetes-sigs · Sep 16, 2021 · e0f56c6 · e0f56c6
2 parents b5e5a82 + 8ea7124
commit e0f56c6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/crd/markers/topology.go b/pkg/crd/markers/topology.go
@@ -101,7 +101,7 @@ type StructType string
 
 func (l ListType) ApplyToSchema(schema *apiext.JSONSchemaProps) error {
 	if schema.Type != "array" {
-		return fmt.Errorf("must apply listType to an array")
+		return fmt.Errorf("must apply listType to an array, found %s", schema.Type)
 	}
 	if l != "map" && l != "atomic" && l != "set" {
 		return fmt.Errorf(`ListType must be either "map", "set" or "atomic"`)
@@ -115,7 +115,7 @@ func (l ListType) ApplyFirst() {}
 
 func (l ListMapKey) ApplyToSchema(schema *apiext.JSONSchemaProps) error {
 	if schema.Type != "array" {
-		return fmt.Errorf("must apply listMapKey to an array")
+		return fmt.Errorf("must apply listMapKey to an array, found %s", schema.Type)
 	}
 	if schema.XListType == nil || *schema.XListType != "map" {
 		return fmt.Errorf("must apply listMapKey to an associative-list")