add a bit more tests for CRD #189
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/cc @redborian |
|
@mengqiy: GitHub didn't allow me to request PR reviews from the following users: redborian. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| }, | ||
| expectedCrdSpecs: map[schema.GroupKind][]byte{ | ||
| schema.GroupKind{Group: "foo.bar.com", Kind: "Toy"}: []byte(`group: foo.bar.com | ||
| names: |
There was a problem hiding this comment.
Just a thought, if we need to write more tests, we can think about having these in their own separate yaml files.
There was a problem hiding this comment.
Generally, the best practice is that "unit tests should not access filesystem".
Echo some benefits mentioned in https://github.com/spf13/afero#using-afero-for-testing
Much faster than performing I/O operations on disk
Avoid security issues and permissions
Far more control. 'rm -rf /' with confidence
Test setup is far more easier to do
No test cleanup needed
We can revisit this if it grow to too large.
mengqiy
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.