Merge pull request #552 from haircommander/golangci-lint-1.19.1

  Download golangci-lint via wget

.travis.yml

@@ -3,7 +3,7 @@ sudo: required
 dist: xenial
 
 go:
-  - 1.12.x
+  - 1.13.x
 
 env:
   - GOPROXY=https://proxy.golang.org
@@ -31,18 +31,14 @@ before_install:
 
 
 install:
-  - make install.tools
+  - make install.ginkgo
 
 jobs:
   include:
     - stage: Static check
       os: linux
       script:
-        - make lint
-        - hack/verify-go-modules.sh
-    - stage: Static check
-      os: linux-ppc64le
-      script:
+        - make install.lint
         - make lint
         - hack/verify-go-modules.sh
     - stage: Build

Makefile

@@ -92,10 +92,18 @@ lint: $(GOLANGCI_LINT)
 	$(GOLANGCI_LINT) run
 	./hack/repo-infra/verify/verify-boilerplate.sh
 
-install.tools: $(GOLANGCI_LINT) $(GINKGO)
+install.tools: install.lint install.ginkgo
+
+install.ginkgo: $(GINKGO)
+install.lint: $(GOLANGCI_LINT)
 
 $(GOLANGCI_LINT):
-	$(call go-build,./vendor/github.com/golangci/golangci-lint/cmd/golangci-lint)
+	export \
+		VERSION=v1.21.0 \
+		URL=https://raw.githubusercontent.com/golangci/golangci-lint \
+		BINDIR=${BUILD_BIN_PATH} && \
+	curl -sfL $$URL/$$VERSION/install.sh | sh -s $$VERSION
+
 
 $(GINKGO):
 	$(call go-build,./vendor/github.com/onsi/ginkgo/ginkgo)

go.mod

@@ -9,7 +9,6 @@ require (
 	github.com/ghodss/yaml v1.0.0
 	github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
 	github.com/golang/protobuf v1.3.2
-	github.com/golangci/golangci-lint v1.17.1
 	github.com/onsi/ginkgo v1.10.1
 	github.com/onsi/gomega v1.7.0
 	github.com/opencontainers/go-digest v1.0.0-rc1
@@ -18,7 +17,7 @@ require (
 	github.com/sirupsen/logrus v1.4.2
 	github.com/urfave/cli v1.22.1
 	golang.org/x/net v0.0.0-20190812203447-cdfb69ac37fc
-	golang.org/x/sys v0.0.0-20190730183949-1393eb018365
+	golang.org/x/sys v0.0.0-20190616124812-15dcb6c0061f
 	google.golang.org/grpc v1.23.0
 	gopkg.in/yaml.v2 v2.2.2
 	k8s.io/api v0.0.0

tools/tools.go

@@ -19,6 +19,5 @@ limitations under the License.
 package tools
 
 import (
-	_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
 	_ "github.com/onsi/ginkgo/ginkgo"
 )