Validate sandbox and container metadata #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
|
/hold Refers to a previous discussion in cri-o/cri-o#3774, cri-o/cri-o#3618 |
k8s-ci-robot
added
the
do-not-merge/hold
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
We pre-validate the container metadata before creation the sandbox/container. Fixes kubernetes-sigs#1273 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
sandbox-container-metadata
branch
from
d96416a to
75c136c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mike-nguyen
added a commit
to mike-nguyen/coreos-assembler
that referenced
this pull request
Dec 14, 2023
Cri-tools 1.29[0] now pre-validates container metadata before
running with crictl[1]. The required uid field was missing in our
test causing the following failure.
```
load podSandboxConfig: name, namespace or uid is not in metadata \"&PodSandboxMetadata{Name:rhcos-crio-pod-restart-test,Uid:,Namespace:redhat.test.crio,Attempt:0,}\
```
[0] https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.29.0
[1] kubernetes-sigs/cri-tools#1274
mike-nguyen
added a commit
to mike-nguyen/coreos-assembler
that referenced
this pull request
Dec 14, 2023
Cri-tools 1.29[0] now pre-validates container metadata before
running with crictl[1]. The required uid field was missing in our
test causing the following failure.
```
load podSandboxConfig: name, namespace or uid is not in metadata \"&PodSandboxMetadata{Name:rhcos-crio-pod-restart-test,Uid:,Namespace:redhat.test.crio,Attempt:0,}\
```
[0] https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.29.0
[1] kubernetes-sigs/cri-tools#1274
mike-nguyen
added a commit
to mike-nguyen/coreos-assembler
that referenced
this pull request
Dec 14, 2023
Cri-tools 1.29[0] now pre-validates container metadata before
running with crictl[1]. The required uid field was missing in our
test causing the following failure.
```
load podSandboxConfig: name, namespace or uid is not in metadata \"&PodSandboxMetadata{Name:rhcos-crio-pod-restart-test,Uid:,Namespace:redhat.test.crio,Attempt:0,}\
```
[0] https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.29.0
[1] kubernetes-sigs/cri-tools#1274
mike-nguyen
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Dec 14, 2023
Cri-tools 1.29[0] now pre-validates container metadata before
running with crictl[1]. The required uid field was missing in our
test causing the following failure.
```
load podSandboxConfig: name, namespace or uid is not in metadata \"&PodSandboxMetadata{Name:rhcos-crio-pod-restart-test,Uid:,Namespace:redhat.test.crio,Attempt:0,}\
```
[0] https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.29.0
[1] kubernetes-sigs/cri-tools#1274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We pre-validate the container metadata before creation the sandbox/container.
Which issue(s) this PR fixes:
Fixes #1273
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?