-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding imagefsinfo endpoint for both container and image filesystems #1295
adding imagefsinfo endpoint for both container and image filesystems #1295
Conversation
@kannon92 we're planning to release cri-tools v1.29.0 before k8s because of the packaging dependencies. Just to keep it in mind if something should land together with Kubernetes. |
It is a new field in CRI but not required. This can go in after the release is bumped. No rush on it. |
aad5cd9
to
79196bb
Compare
Signed-off-by: Kevin Hannon <kehannon@redhat.com>
79196bb
to
c5e443a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Should be good to go now since #1300 was merged
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update ImageFsInfo to reflect new CRI update in 1.29.
Which issue(s) this PR fixes:
Updates for KEP-4191.
Special notes for your reviewer:
Mergable once 1.29 is released. Currently, I am vendoring the cri changes for now.
Does this PR introduce a user-facing change?