Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding imagefsinfo endpoint for both container and image filesystems #1295

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update ImageFsInfo to reflect new CRI update in 1.29.

Which issue(s) this PR fixes:

Updates for KEP-4191.

Special notes for your reviewer:

Mergable once 1.29 is released. Currently, I am vendoring the cri changes for now.

Does this PR introduce a user-facing change?

Allow for imagefsinfo to report container_filesystem and image_filesystem.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 20, 2023
@saschagrunert
Copy link
Member

@kannon92 this one will conflict with #1300 once merged. Are you still working on this or should we take it over?

@kannon92
Copy link
Contributor Author

@kannon92 this one will conflict with #1300 once merged. Are you still working on this or should we take it over?

I was expecting conflicts once 1.29 was released. I can resolve those once #1300 is merged. I mostly opened this up in preparation for when 1.29 is released.

@saschagrunert
Copy link
Member

@kannon92 we're planning to release cri-tools v1.29.0 before k8s because of the packaging dependencies. Just to keep it in mind if something should land together with Kubernetes.

@kannon92
Copy link
Contributor Author

@kannon92 we're planning to release cri-tools v1.29.0 before k8s because of the packaging dependencies. Just to keep it in mind if something should land together with Kubernetes.

It is a new field in CRI but not required. This can go in after the release is bumped. No rush on it.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 4, 2023
@kannon92 kannon92 changed the title wip: adding imagefsinfo endpoint for both container and image filesystems adding imagefsinfo endpoint for both container and image filesystems Dec 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2023
Signed-off-by: Kevin Hannon <kehannon@redhat.com>
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Should be good to go now since #1300 was merged

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 046e620 into kubernetes-sigs:master Dec 4, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants