Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image RPCs interruptable using Ctrl-C #1462

Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

All image related RPCs are now interruptable using Ctrl-C.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Make image related commands interruptable using Ctrl-C.

All image related RPCs are now interruptable using Ctrl-C.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2024
@haircommander
Copy link
Contributor

nice use of generics
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8516ef8 into kubernetes-sigs:master Jun 21, 2024
23 checks passed
@saschagrunert saschagrunert deleted the interruptable-image branch June 21, 2024 15:35
saschagrunert pushed a commit to saschagrunert/cri-tools that referenced this pull request Jun 24, 2024
…ble-image

Make image RPCs interruptable using Ctrl-C

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert pushed a commit to saschagrunert/cri-tools that referenced this pull request Jun 24, 2024
…ble-image

Make image RPCs interruptable using Ctrl-C

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert pushed a commit to saschagrunert/cri-tools that referenced this pull request Jun 24, 2024
…ble-image

Make image RPCs interruptable using Ctrl-C

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert pushed a commit to saschagrunert/cri-tools that referenced this pull request Jun 24, 2024
…ble-image

Make image RPCs interruptable using Ctrl-C

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants