Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log message for AppArmor profiles #1509

Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

There is no output from apparmor_parser while loading the profiles, which results in meaningless messages during the tests like:

time="2024-07-22T08:51:18Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:18Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:19Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:19Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:20Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:20Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:21Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:21Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:21Z" level=info msg="Loaded profiles: []"

We can skip this message and only report errors for the preloading of profiles.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Removed meaningless `"Loaded profiles: []"` message during AppArmor `critest` suite runs.

There is no output from `apparmor_parser` while loading the profiles,
which results in meaningless messages during the tests like:

```
time="2024-07-22T08:51:18Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:18Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:19Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:19Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:20Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:20Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:21Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:21Z" level=info msg="Loaded profiles: []"
time="2024-07-22T08:51:21Z" level=info msg="Loaded profiles: []"
```

We can skip this message and only report errors for the preloading of
profiles.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2024
@kwilczynski
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8332eef into kubernetes-sigs:master Jul 22, 2024
23 checks passed
@saschagrunert saschagrunert deleted the apparmor-loaded-profiles branch July 22, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants