Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OOMKilled test assertions #1546

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix OOMKilled test assertions #1546

merged 1 commit into from
Aug 5, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 1, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixing the assertions to make the results check work.

Which issue(s) this PR fixes:

Refers to cri-o/cri-o#8411

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed critest out of memory (OOM) test assertions to actually match the results.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 1, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2024
@saschagrunert saschagrunert force-pushed the oom branch 5 times, most recently from a4b993b to dfee012 Compare August 2, 2024 07:57
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2024
@saschagrunert saschagrunert force-pushed the oom branch 2 times, most recently from 32ffda3 to ff56cd5 Compare August 2, 2024 08:11
@saschagrunert saschagrunert force-pushed the oom branch 7 times, most recently from bfef7d7 to cf5da14 Compare August 2, 2024 09:42
@saschagrunert
Fix OOMKilled test
22d7ff9 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024
SergeyKanzhelev
SergeyKanzhelev approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2024
@SergeyKanzhelev
Copy link
Member

lgtm-ed to make it merged once fixed. The change in test is good

@kwilczynski
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert changed the title WIP: Fix OOMKilled test assertions Fix OOMKilled test assertions Aug 5, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
@saschagrunert
Copy link
Member Author

Should be fixed with https://github.com/containers/conmon-rs/releases/tag/v0.6.4

@k8s-ci-robot k8s-ci-robot merged commit 8aed864 into kubernetes-sigs:master Aug 5, 2024
29 checks passed
@saschagrunert saschagrunert deleted the oom branch August 5, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@klueska klueska Awaiting requested review from klueska

Assignees

@kwilczynski kwilczynski

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @SergeyKanzhelev @kwilczynski @k8s-ci-robot