Add TLS support for crictl exec, portforward and attach
#1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/XL
saschagrunert
force-pushed
the
attach-exec-tls
branch
from
a3faa62 to
9c8cb37
Compare
k8s-ci-robot
added
size/L
cmd/crictl/attach.go
Outdated
| &cli.StringFlag{ | ||
| Name: flagTLSServerName, | ||
| Usage: "Server name used in the TLS client to check server certificates against", | ||
| Aliases: []string{"tls-server", "tls-sn"}, |
There was a problem hiding this comment.
should it be tls-sni like https://en.wikipedia.org/wiki/Server_Name_Indication?
There was a problem hiding this comment.
Yes, changed as suggested and kept the tls-server-name alias.
Add flags to allow using the TLS based streaming configuration. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
attach-exec-tls
branch
from
9c8cb37 to
2cf1580
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add flags to allow using the TLS based streaming configuration.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?