Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splits install and uninstall actions for those who need only one of.. #234

Merged

Conversation

mikebrow
Copy link
Contributor

@mikebrow mikebrow commented Feb 6, 2018

This PR addresses issue #233 to split up install and uninstall into separate installs and uninstalls for crictl and critest. Build is already split up..

@random-li

Signed-off-by: Mike Brown brownwm@us.ibm.com

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2018
@feiskyer
Copy link
Member

feiskyer commented Feb 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
@feiskyer feiskyer merged commit ded07bb into kubernetes-sigs:master Feb 7, 2018
@Random-Liu
Copy link
Contributor

Nice! Thanks! @mikebrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants