Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubelet 1.10.X for release-1.10 CI #295

Merged
merged 1 commit into from
May 15, 2018
Merged

Use kubelet 1.10.X for release-1.10 CI #295

merged 1 commit into from
May 15, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented May 2, 2018 •
edited
Loading

Fixes #294

Depending on kubernetes/kubernetes#63387.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2018
@feiskyer feiskyer mentioned this pull request May 2, 2018
Closed
@Random-Liu
Copy link
Contributor

Random-Liu commented May 2, 2018 •
edited
Loading

@feiskyer Should we only cherrypick this to 1.10 branch? Don't think we should skip RunAsGroup test in HEAD.

@umohnani8
Copy link
Contributor

@feiskyer it says you want to merge this into master, it should be for release-1.10 right?

@feiskyer feiskyer changed the base branch from master to release-1.10 May 3, 2018 01:29
@feiskyer
Copy link
Member Author

feiskyer commented May 3, 2018

@umohnani8 Oops, sent to wrong branch. Reset to release-1.10 branch now.

@feiskyer
Copy link
Member Author

feiskyer commented May 3, 2018

@Random-Liu Right, we should cherry-pick the fixes to 1.10, filed kubernetes/kubernetes#63387 for it

@Random-Liu
Copy link
Contributor

Random-Liu commented May 3, 2018 •
edited
Loading

@feiskyer The error is caused by missing of kubernetes/kubernetes@cfcf9d8, which is only in HEAD.

I think we should remove that test from 1.10 branch.

@feiskyer
Copy link
Member Author

feiskyer commented May 4, 2018

@Random-Liu Filed kubernetes/kubernetes#63387 to cherry pick it

@umohnani8
Copy link
Contributor

@feiskyer any idea how long till this gets into the 1.10 branch?

@feiskyer
Copy link
Member Author

@umohnani8 Still need another approval now

@umohnani8
Copy link
Contributor

@feiskyer great! Looks like kubernetes/kubernetes#63387 got merged.
LGTM

@feiskyer
Copy link
Member Author

/assign @Random-Liu

@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2018
@Random-Liu Random-Liu merged commit 1e5a82d into kubernetes-sigs:release-1.10 May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feiskyer @Random-Liu @umohnani8 @k8s-ci-robot