-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker installation for CI #445
Fix docker installation for CI #445
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is a behavior change in the new docker. For Docker 17.03, exec process inherits additional group id from the init process:
For Docker 18.09, exec process doesn't inherit additional group id from the init process:
I'm investigating why the change was made. Tell me if you have more information about this. :) |
OK. I think this is a docker bug introduced after switching to containerd 1.0. Will file a docker issue and link here. |
See moby/moby#38865 |
@Random-Liu Thanks for the tip, didn't notice this bug. Let me switch to 18.03 then. |
49fbcdb
to
199c41d
Compare
199c41d
to
fe78111
Compare
fe78111
to
0651ca7
Compare
Dockershim panic now with errors:
Filed kubernetes/kubernetes#75367 to fix this issue. |
0651ca7
to
4706f58
Compare
This is actually a workaround for kubernetes/kubernetes#75367. It would be removed after the upstream PR #75367 got merged.
For workarounds, the tests for triggering dockershim panic have been skipped. Self applied lgtm since it also blocks other PRs. |
Fix docker installation for CI and upgrade docker version to
18.0617.03.Update: older version 17.03 is used because of two reasons: