Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attach test on windows. #533

Merged

Conversation

Random-Liu
Copy link
Contributor

@Random-Liu Random-Liu commented Sep 12, 2019

See https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/containerd_cri/1264/pull-cri-containerd-windows-cri/1171919947392094208

On windows, if we attach to the container too early, we may get extra output:

C:/Users/prow/AppData/Local/Temp/cri-install-crictl.6mPD/src/github.com/kubernetes-sigs/cri-tools/pkg/validate/streaming.go:109
Timed out after 60.011s.
The stdout of attach should be hello
Expected
    <string>: Microsoft Windows [Version 10.0.17763.737]
    (c) 2018 Microsoft Corporation. All rights reserved.
    
    C:\>hello
    
    C:\>
to equal
    <string>: hello
    
    C:\>
C:/Users/prow/AppData/Local/Temp/cri-install-crictl.6mPD/src/github.com/kubernetes-sigs/cri-tools/pkg/validate/streaming.go:298

We should wait for the output to be stable before feeding in the input command.
Signed-off-by: Lantao Liu lantaol@google.com

Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2019
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 84b8540 into kubernetes-sigs:master Sep 12, 2019
@Random-Liu Random-Liu deleted the fix-attach-on-windows branch September 12, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants