Pass pod config when pulling image during create

[kevpar]

Signed-off-by: Kevin Parsons kevpar@microsoft.com

The change to pull image as part of container create broke LCOW (Linux Containers on Windows), as it depends on knowing the pod config at pull time to select the correct snapshotter. We already have the pull config available in this function, so this change just passes it through to the pull operation.

[k8s-ci-robot]

Welcome @kevpar!

It looks like this is your first PR to kubernetes-sigs/cri-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cri-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[jterry75]

@Random-Liu - Why is this code ever here? We do not allow CRI to pull the image at ContainerCreate time in the daemon why do we do it client side. I don't see really why this expectation is an improvement over just issuing the set of crictl pull requests that you need and then separately the crictl create requests. Seems like business logic in crictl vs just a cmdline invocation around CRI API. Thoughts?

[feiskyer]

@Random-Liu - Why is this code ever here? We do not allow CRI to pull the image at ContainerCreate time in the daemon why do we do it client side. I don't see really why this expectation is an improvement over just issuing the set of crictl pull requests that you need and then separately the crictl create requests. Seems like business logic in crictl vs just a cmdline invocation around CRI API. Thoughts?

This is client side change only for crictl. In Kubelet, the image would be pulled before creating the container; while in crictl, image is also pulled to make crictl easier to use.

[feiskyer]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, kevpar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jterry75]

@feiskyer - Thanks!

[cgwalters]

Could this have caused #548 ?

[jterry75]

@cgwalters - Seems very likely yes.