Switch to urfave/cli/v2 #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
saschagrunert
force-pushed
the
urfave-cli-2
branch
from
b769057 to
0aec80c
Compare
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XXL
saschagrunert
force-pushed
the
urfave-cli-2
branch
from
0aec80c to
c692cc4
Compare
|
PR needs rebase |
k8s-ci-robot
added
the
needs-rebase
The latest release of the command line parser has some breaking changes which are included in this commit as well. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
saschagrunert
force-pushed
the
urfave-cli-2
branch
from
c692cc4 to
3216a7e
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Rebased on top of the latest master. I don't think that this has to be part of the release, so there is no rush. |
feiskyer
reviewed
Feb 11, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of the command line parser has some breaking changes
which are included in this commit as well.