cmd: add go-template option for inspect commands #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @feiskyer |
cmd/crictl/templates.go
Outdated
| @@ -0,0 +1,71 @@ | |||
| /* | |||
| Copyright 2017 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Suggested change
| Copyright 2017 The Kubernetes Authors. | |
| Copyright 2020 The Kubernetes Authors. |
cmd/crictl/templates.go
Outdated
| "strings" | ||
| "text/template" | ||
|
|
||
| pkgerrors "github.com/pkg/errors" |
There was a problem hiding this comment.
Suggested change
| pkgerrors "github.com/pkg/errors" | |
| "github.com/pkg/errors" |
cmd/crictl/templates_test.go
Outdated
| @@ -0,0 +1,66 @@ | |||
| /* | |||
| Copyright 2017 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Suggested change
| Copyright 2017 The Kubernetes Authors. | |
| Copyright 2020 The Kubernetes Authors. |
go.mod
Outdated
| @@ -14,6 +14,7 @@ require ( | |||
| github.com/opencontainers/go-digest v1.0.0-rc1 | |||
| github.com/opencontainers/selinux v1.3.1-0.20190929122143-5215b1806f52 | |||
| github.com/pborman/uuid v1.2.0 | |||
| github.com/pkg/errors v0.8.1 | |||
There was a problem hiding this comment.
Suggested change
| github.com/pkg/errors v0.8.1 | |
| github.com/pkg/errors v0.9.1 |
fuweid
force-pushed
the
me-add-template-output
branch
from
33d382d to
143cad8
Compare
|
@saschagrunert thank you for review! Updated. PTAL |
fuweid
force-pushed
the
me-add-template-output
branch
2 times, most recently
from
5850928 to
3b82868
Compare
1. Add github.com/pkg/errors package in go.mod;
2. Add go-template value and template option to
inspect{,p,i}/info/imagesfsinfo subcommands;
3. Add "table" as default value in ps/pods subcommands.
Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
force-pushed
the
me-add-template-output
branch
from
3b82868 to
e602578
Compare
|
Is there anything wrong about |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspect{,p,i}/info/imagesfsinfo subcommands;
Signed-off-by: Wei Fu fuweid89@gmail.com