Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pod sandoxes in parallel #583

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Remove pod sandoxes in parallel #583

merged 1 commit into from
Apr 6, 2020

Conversation

saschagrunert
Copy link
Member

We now use a classic work-stealing approach to remove the sandboxes in
parallel if multiple are defined.

/cc @ereslibre

@k8s-ci-robot
Copy link
Contributor

@saschagrunert: GitHub didn't allow me to request PR reviews from the following users: ereslibre.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

We now use a classic work-stealing approach to remove the sandboxes in
parallel if multiple are defined.

/cc @ereslibre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2020
feiskyer
feiskyer reviewed Apr 4, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about using AggregateGoroutines?

@saschagrunert
Remove pod sandoxes in parallel
1655f54 
We now use a classic work-stealing approach to remove the sandboxes in
parallel if multiple are defined.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

what about using AggregateGoroutines?

Thanks for the hint, used the suggested API in the implementation 👍

feiskyer
feiskyer approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 719b9ad into kubernetes-sigs:master Apr 6, 2020
@saschagrunert saschagrunert deleted the remove-prallel branch April 6, 2020 11:08
This was referenced Aug 31, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @k8s-ci-robot @feiskyer