Add timeout option to CreateContainer, RunContainer, RunPodSandbox #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/M
|
haha @ the PR number 😈 |
saschagrunert
requested changes
Sep 24, 2020
This option allows users to test their CRI implementation with a timeout, similarly to how the kubelet runs requests. Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
request-timeout
branch
from
b653c42 to
250d3a7
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add timeout option to CreateContainer, RunContainer, RunPodSandbox
This option allows users to test their CRI implementation with a timeout,
similarly to how the kubelet runs requests.
Signed-off-by: Peter Hunt pehunt@redhat.com
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?