Timeout fixes #668
Merged
Timeout fixes #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/S
haircommander
force-pushed
the
timeout-fixes
branch
3 times, most recently
from
4019c08 to
ea40d4c
Compare
Before, we were always multiplying the timeout by time.Seconds, instead of using the time.Duration provided to us Signed-off-by: Peter Hunt <pehunt@redhat.com>
there already exists a top level `-t` option for a timeout for connecting to the server If we overload `-t`, users (read: I) could get confused and specify it in the wrong place. Change the `--timeout` option for cancelling the context to `cancel-timeout` with the short option of `-T` Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
timeout-fixes
branch
from
ea40d4c to
14b15fe
Compare
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind api-change
What this PR does / why we need it:
Adds two fixes to the runp/create
--timeoutfeature1: correctly use the timeout passed in by not multiplying it by time.Seconds (a relic from when it was originally specified as an int, oops)
2: change the option to
--cancel-timeoutand-Tto not overload--timeoutand-t(Which has a different meaning in the top level flags, and could confuse users)Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?