Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify hack/release.sh script to include sha256 sum files #717

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

We now add a *.sha256 file side by side to the tarball, which can be
uploaded as GitHub artifact. Beside this, the script now directly
outputs the Markdown table to lazy copy-paste. The script also now
includes the full file which has been build and not only it's name to
provide a more useful and verbose output.

Which issue(s) this PR fixes:

Closes #716

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added *.sha256 sum files to release artifacts

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2021
hack/release.sh Outdated Show resolved Hide resolved
We now add a *.sha256 file side by side to the tarball, which can be
uploaded as GitHub artifact. Beside this, the script now directly
outputs the Markdown table to lazy copy-paste. The script also now
includes the full file which has been build and not only it's name to
provide a more useful and verbose output.

Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 030052a into kubernetes-sigs:master Jan 29, 2021
@saschagrunert saschagrunert deleted the shasum branch February 1, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide .sha256 files in release artifiacts
3 participants