-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global signal handler for Interrupt signal #720
Conversation
Welcome @povsister! |
Just new to crictl, remind me if I am missing other long-running commands which also require signal handling. |
300984f
to
b584ae2
Compare
/auto-cc |
Fix CtrlC not working with "crictl logs -f" command. Switch to the global signal handler in following commands: * crictl port-forward * crictl stats -w Signed-off-by: povsister <pov@mahou-shoujo.moe>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
PTAL @feiskyer
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: povsister, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this
/hold cancel
What type of PR is this?
/kind bug
/sig node
What this PR does / why we need it:
Fix Ctrl+C not working with "crictl logs -f" command.
Switch to the global signal handler in following commands:
Which issue(s) this PR fixes:
Fixes #673
Special notes for your reviewer:
This PR also introduces a global Interrupt signal handling mechanism for long-running commands.
When programmer calls
SetupInterruptSignalHandler()
, a global read-onlystopCh
is returned.Behind the scene:
stopCh
will be closed when Interrupt signal received.SetupInterruptSignalHandler()
is not called.Does this PR introduce a user-facing change?