-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to CRI v1 API #878
Switch to CRI v1 API #878
Conversation
df68ed7
to
32693fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase the PR again?
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this PR makes the cri tools incompatible with the Containerd 1.5. Which is not ideal. As a minimum this needs to be communicated in readme and release notes. This may break users so implementing the fallback logic would be the best. |
cri-tools is versioned with kubernetes version, and should support the same set of CRI versions with Kubernetes. @SergeyKanzhelev told me that we have conversion logic in Kubernetes to fallback to v1alpha2, can we reuse that in cri-tools? |
Created tracking task: #883 Since it is in master targeting 1.24 there is still some time to implement it. |
crictl is compatible with the stable api since kubernetes-sigs/cri-tools#878
What type of PR is this?
/kind feature
What this PR does / why we need it:
Using the CRI v1 API as new default.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?