Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update containerd socket in windows #914

Merged
merged 1 commit into from
May 2, 2022
Merged

update containerd socket in windows #914

merged 1 commit into from
May 2, 2022

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Apr 15, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

The containerd socket in windows is wrong.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

change default contained socket from `npipe:////./pipe/containerd` to `npipe:////./pipe/containerd-containerd`

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2022
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp April 15, 2022 10:43
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tallclair April 15, 2022 10:43
SergeyKanzhelev
SergeyKanzhelev reviewed Apr 15, 2022
View reviewed changes
cmd/crictl/main_windows.go
@@ -23,7 +23,7 @@ import (
"path/filepath"
)

var defaultRuntimeEndpoints = []string{"npipe:////./pipe/dockershim", "npipe:////./pipe/containerd", "npipe:////./pipe/crio", "npipe:////./pipe/cri-dockerd"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does crio support windows at all? Perhaps it can be removed.

SergeyKanzhelev
SergeyKanzhelev approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

maybe also delete cri-o, I believe it doesn't support windows

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2022
@hwdef
Copy link
Member Author

hwdef commented Apr 16, 2022

@SergeyKanzhelev
Yes, you are right. I deleted cri-o for windows.

SergeyKanzhelev
SergeyKanzhelev approved these changes Apr 17, 2022
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2022
@hwdef
Copy link
Member Author

hwdef commented Apr 18, 2022

@SergeyKanzhelev
Do you have any opinion about CI's error? After reading the error log, I think the part I modified has nothing to do with the wrong part of CI.

@SergeyKanzhelev
Copy link
Member

no successful un since this message: #908 (comment)

definitely not caused by this PR

@SergeyKanzhelev
Copy link
Member

likely caused by containerd/containerd#6721

cc: @mikebrow

FYI

@hwdef
Copy link
Member Author

hwdef commented Apr 18, 2022

I see, thank you.

@mikebrow
Copy link
Contributor

mikebrow commented Apr 18, 2022 •
edited
Loading

On the linux main CI bug ^

looks like the linux runs are missing the command to install the latest cni plugins and config dependencies.. and whatever cni was already there on the runner is old.. wrt the loopback plugin.. so when containerd tries to load it up using the built in cni v1.0.0 configuration for loopback.. it fails..

The way we install cni over in containerd in our ci is as follows:

via the following ci yaml

          sudo -E PATH=$PATH script/setup/install-cni $(grep containernetworking/plugins go.mod | awk '{print $2}')

see script here: https://github.com/containerd/containerd/blob/main/script/setup/install-cni

On the windows issue(s) we did a few changes to the critest on windows setup that probably need to be mirrored here @kevpar heads up..

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Apr 18, 2022
Merged
@saschagrunert
Copy link
Member

@hwdef can you please rebase to get the latest CI changes in?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@hwdef
Copy link
Member Author

hwdef commented May 2, 2022

@hwdef can you please rebase to get the latest CI changes in?

ok.

saschagrunert
saschagrunert approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit ee5fdb1 into kubernetes-sigs:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@saschagrunert saschagrunert

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwdef @SergeyKanzhelev @mikebrow @saschagrunert @k8s-ci-robot