Migrate to native ginkgo v2 #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
approved
Two migrations needs to be done to avoid the following warnings: ``` You're using deprecated Ginkgo functionality: ============================================= Support for custom reporters has been removed in V2. Please read the documentation linked to below for Ginkgo's new behavior and for a migration path: Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters Measure is deprecated and will be removed in Ginkgo V2. Please migrate to gomega/gmeasure. Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-measure github.com/kubernetes-sigs/cri-tools/pkg/benchmark/pod_container.go:60 ``` Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
ginkgo-migration
branch
from
876ba45 to
7cf65e1
Compare
k8s-ci-robot
added
size/L
mikebrow
reviewed
May 24, 2022
|
@feiskyer PTAL |
|
How about getting this in before v1.25.0? |
Closed
feiskyer
reviewed
Aug 26, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aznashwan
added a commit
to aznashwan/cri-tools
that referenced
this pull request
Aug 30, 2022
Following the switch to Ginkgo v2 in kubernetes-sigs#938, running `critest` without the `-benchmark` flag will erroneously run some benchmark specs alongside the validation ones too. This patch ensures that all specs containing "benchmark" will be skipped unless the `-benchmark` flag is explicitly provided. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
aznashwan
added a commit
to aznashwan/cri-tools
that referenced
this pull request
Aug 30, 2022
Following the switch to Ginkgo v2 in kubernetes-sigs#938, running `critest` without the `-benchmark` flag will erroneously run some benchmark specs alongside the validation ones too. This patch ensures that all specs containing "benchmark" will be skipped unless the `-benchmark` flag is explicitly provided. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
aznashwan
added a commit
to aznashwan/cri-tools
that referenced
this pull request
Aug 30, 2022
Following the switch to Ginkgo v2 in kubernetes-sigs#938, running `critest` without the `-benchmark` flag will erroneously run some benchmark specs alongside the validation ones too. This patch ensures that all specs containing "benchmark" will be skipped unless the `-benchmark` flag is explicitly provided. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Two migrations needs to be done to avoid the following warnings:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?