-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print deleted digest when repo tags empty #979
Print deleted digest when repo tags empty #979
Conversation
|
Welcome @thomasf7! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, thomasf7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR updates the
crictl rmi
command to print the repoDigests of deleted images where the image has no repoTags, which can happen when the image digest is used for pulling the image. Currently when this happens the images are deleted with no output whatsoever to indicate this has happened.Which issue(s) this PR fixes:
Fixes #976
Special notes for your reviewer:
Does this PR introduce a user-facing change?