update docs with helm test info

kubernetes-sigs · Apr 14, 2021 · c05d36d · c05d36d
1 parent 92cb1b2
commit c05d36d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/charts/descheduler/templates/tests/test-descheduler-pod.yaml b/charts/descheduler/templates/tests/test-descheduler-pod.yaml
@@ -17,7 +17,7 @@ spec:
               drop:
                 - All
             privileged: false
-            runAsNonRoot: false
+            runAsNonRoot: false 
         command: ["/bin/ash"]
         args:
           - -c
@@ -26,4 +26,4 @@ spec:
             curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl &&
             chmod +x ./kubectl &&
             mv ./kubectl /usr/local/bin/kubectl &&
-            /usr/local/bin/kubectl get pods --namespace kube-system --token "$(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" | grep "Completed"
+            /usr/local/bin/kubectl get pods --namespace kube-system --token "$(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" | grep "descheduler" | grep "Completed"
diff --git a/docs/contributor-guide.md b/docs/contributor-guide.md
@@ -39,5 +39,18 @@ make test-unit
 make test-e2e
 ```
 
+## Run Helm tests
+We can run the helm test for a particular descheduler release by setting below variables,
+```
+HELM_IMGAE_REPO="descheduler"
+HELM_IMAGE_TAG="helm-test"
+CHARTS_PATH="./charts/descheduler"
+```
+The helm tests runs as part of descheduler CI. But, to run it manually from the descheduler root,
+
+```
+make test-helm
+```
+
 ### Miscellaneous
 See the [hack directory](https://github.com/kubernetes-sigs/descheduler/tree/master/hack) for additional tools and scripts used for developing the descheduler.