-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin arguments defaulting + moving plugin arguments to each corresponding plugin #925
Comments
As a reference for anyone who wants to pick it up, #900 is an example of what we mean by |
/assign |
Plugin arguments defaulting + moving plugin arguments to each corresponding plugin #925
/close |
@damemi: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://github.com/kubernetes-sigs/descheduler/pull/1006/files#diff-0129f73a80ed727af36e1b6007786fd044191cafed0900875f5a90b38ea33739R86 for wiring the defaulting of arguments |
All plugin arguments need to be defaulted so a user is not required to specify every available argument. Also, to improve plugin modularity it's preferable to move corresponding plugin argument type to its plugin. So both defaulting and validation code is not separated from the plugin itself.
The text was updated successfully, but these errors were encountered: