Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin arguments defaulting + moving plugin arguments to each corresponding plugin #925

Closed
ingvagabund opened this issue Aug 25, 2022 · 5 comments
Assignees

Comments

@ingvagabund
Copy link
Contributor

All plugin arguments need to be defaulted so a user is not required to specify every available argument. Also, to improve plugin modularity it's preferable to move corresponding plugin argument type to its plugin. So both defaulting and validation code is not separated from the plugin itself.

@damemi
Copy link
Contributor

damemi commented Aug 25, 2022

As a reference for anyone who wants to pick it up, #900 is an example of what we mean by Also, to improve plugin modularity it's preferable to move corresponding plugin argument type to its plugin. So both defaulting and validation code is not separated from the plugin itself.

@spike-liu
Copy link
Contributor

/assign

k8s-ci-robot added a commit that referenced this issue Sep 27, 2022
Plugin arguments defaulting + moving plugin arguments to each corresponding plugin #925
@damemi
Copy link
Contributor

damemi commented Nov 3, 2022

/close
done in #954

@k8s-ci-robot
Copy link
Contributor

@damemi: Closing this issue.

In response to this:

/close
done in #954

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants