Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to k8s 1.26 #1015

Merged
merged 1 commit into from
Dec 28, 2022
Merged

bump to k8s 1.26 #1015

merged 1 commit into from
Dec 28, 2022

Conversation

JaneLiuL
Copy link
Member

@JaneLiuL JaneLiuL commented Dec 12, 2022

as title and issue #1013

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2022
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks @JaneLiuL !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@a7i
Copy link
Contributor

a7i commented Dec 13, 2022

/hold
/lgtm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@a7i
Copy link
Contributor

a7i commented Dec 13, 2022

@JaneLiuL Created the Issue and updated the Project board accordingly: https://github.com/orgs/kubernetes-sigs/projects/22/views/1

@JaneLiuL
Copy link
Member Author

thanks, @a7i i saw the board already have the issue, what do i need to do ?

@damemi
Copy link
Contributor

damemi commented Dec 13, 2022

@a7i was there anything else holding this or good to merge?

(thanks for updating the project board btw!)

@a7i
Copy link
Contributor

a7i commented Dec 13, 2022

@damemi I am trying to fix the build timeout issue before we merge any additional PR. The last push failed

@JaneLiuL
Copy link
Member Author

so can be merge this first? @damemi

@damemi
Copy link
Contributor

damemi commented Dec 14, 2022

@JaneLiuL not yet, let's merge #1019 first (and some other less critical PRs) to make sure the builds aren't timing out any more before we merge this. Want to make sure the GA bump lands smoothly and builds

@JaneLiuL
Copy link
Member Author

ok, i check #1019 already merge done.

@damemi
Copy link
Contributor

damemi commented Dec 15, 2022

@JaneLiuL yeah, unfortunately it didn't fix the problem like we expected (see #1023). This is why we want to find a fix first, then merge some other PRs before this one to test that the fix works.

We'll merge this as soon as we're sure we can get our builds to complete

@a7i
Copy link
Contributor

a7i commented Dec 28, 2022

@damemi and @JaneLiuL Given that we are temporarily unblocked (given the increased timeout), I'm going to /unhold this PR.

@a7i
Copy link
Contributor

a7i commented Dec 28, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit a7c16d9 into kubernetes-sigs:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants