Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logo in readme #1016

Merged
merged 1 commit into from
Dec 13, 2022
Merged

logo in readme #1016

merged 1 commit into from
Dec 13, 2022

Conversation

knelasevero
Copy link
Contributor

@knelasevero knelasevero commented Dec 12, 2022 •
edited
Loading

adding logo that was accepted into the project's readme

related to #978 and cncf/artwork#374

Closes #978

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2022
@knelasevero
Copy link
Contributor Author

Preview here: https://github.com/kubernetes-sigs/descheduler/blob/97c22e1e4b03b25b6e858aed1a5d202db589d08c/README.md

Please let me know if bigger or smaller or not centered is of your preference

damemi
damemi reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Looks awesome, thanks @knelasevero!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@a7i
Copy link
Contributor

a7i commented Dec 13, 2022

Awesome!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9f6afd4 into kubernetes-sigs:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@JaneLiuL JaneLiuL Awaiting requested review from JaneLiuL

Assignees

@a7i a7i

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logo proposal for the project
4 participants
@knelasevero @k8s-ci-robot @a7i @damemi