Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version references in docs and readme #1018

Merged
merged 1 commit into from
Dec 14, 2022
Merged

update version references in docs and readme #1018

merged 1 commit into from
Dec 14, 2022

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Dec 13, 2022 •
edited by damemi
Loading

closes #1009

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2022
@damemi
Copy link
Contributor

damemi commented Dec 13, 2022

/retest
hopefully timeout on golangci-lint is a flake 😭

damemi
damemi reviewed Dec 13, 2022
View reviewed changes
test/run-e2e-tests.sh
@@ -25,9 +25,9 @@ SKIP_INSTALL=${SKIP_INSTALL:-}
if [ -n "$KIND_E2E" ]; then
# If we did not set SKIP_INSTALL
if [ -z "$SKIP_INSTALL" ]; then
K8S_VERSION=${KUBERNETES_VERSION:-v1.25.0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaneLiuL also has this change in her 1.26 ga bump: https://github.com/kubernetes-sigs/descheduler/pull/1015/files#diff-b99dcd844076be461a8082515888ea0300eff8977140a8df03cc91a2c829a6c6, fyi one of you may need to rebase

@ingvagabund
Copy link
Contributor

/approve

@damemi
Copy link
Contributor

damemi commented Dec 13, 2022

/hold
while we work out postsubmit timeouts

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@damemi
Copy link
Contributor

damemi commented Dec 14, 2022

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@damemi
Copy link
Contributor

damemi commented Dec 14, 2022

/approve
don't know why it didn't apply Jan's

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3d70664 into kubernetes-sigs:master Dec 14, 2022
@a7i a7i deleted the docs-1.26 branch December 14, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@JaneLiuL JaneLiuL Awaiting requested review from JaneLiuL

Assignees

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update version references in docs and readme
4 participants
@a7i @damemi @ingvagabund @k8s-ci-robot