Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "parallelize docker build for each arch" #1029

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Revert "parallelize docker build for each arch" #1029

merged 1 commit into from
Dec 22, 2022

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Dec 22, 2022

Reverts #1019

We didn't see any gains from running builds in parallel

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 22, 2022
@a7i
Copy link
Contributor Author

a7i commented Dec 22, 2022

/cc @damemi

@a7i
Copy link
Contributor Author

a7i commented Dec 22, 2022

/retest

damemi
damemi reviewed Dec 22, 2022
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine reverting this, but I have a feeling we'll end up doing something like it once we figure out how to parallelize these.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2022
@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3c80f33 into kubernetes-sigs:master Dec 22, 2022
@a7i a7i deleted the revert-1019-parallel-docker-build branch December 22, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@JaneLiuL JaneLiuL Awaiting requested review from JaneLiuL

Assignees

@seanmalloy seanmalloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7i @k8s-ci-robot @seanmalloy @damemi