Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default value assignment of EvictLocalStoragePods #1106

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Apr 3, 2023

Patching 0.26 (0.26.1)
#1104 (comment)

Signed-off-by: yanggang <gang.yang@daocloud.io>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2023
@a7i a7i changed the title fix if condition for the right value of EvictLocalStoragePods fix default value assignment of EvictLocalStoragePods Apr 3, 2023
@a7i
Copy link
Contributor Author

a7i commented Apr 3, 2023

/cc @ingvagabund

@ingvagabund
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2023
@knelasevero
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5f1b31f into kubernetes-sigs:release-1.26 Apr 3, 2023
@damemi
Copy link
Contributor

damemi commented Apr 3, 2023

@a7i should I push a v0.26.1 tag to the release branch so we can start the patch release process?

@a7i a7i deleted the release-1.26-patch branch April 3, 2023 12:55
@a7i
Copy link
Contributor Author

a7i commented Apr 3, 2023

@damemi yes, please. how do I go about getting permission to create tags?

@damemi
Copy link
Contributor

damemi commented Apr 3, 2023

@a7i I think we update https://github.com/kubernetes/org/blob/b7bd5eb8af25bd3c5917bf5ecee720e84ee7095b/config/kubernetes-sigs/sig-scheduling/teams.yaml#L20-L28

We should really work on a way to automate our release flow instead of having one person manually push a tag right to remote (😬). Something like an issue or PR merge that requires at least a second person to lgtm/approve would be cool. For me, this tag push is the most stressful part of each release because I worry about messing it up. We could probably set up a github action to do that.

For now, v0.26.1 is pushed

@damemi
Copy link
Contributor

damemi commented Apr 3, 2023

For me, this tag push is the most stressful part of each release because I worry about messing it up.

And as if on cue, I messed this one up by pushing a bunch of junk local tags. Hope I didn't mess up deleting them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants