Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.28.1 #1285

Merged
merged 26 commits into from
Nov 16, 2023
Merged

Release 1.28.1 #1285

merged 26 commits into from
Nov 16, 2023

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Nov 2, 2023

a7i and others added 26 commits August 24, 2023 08:32
…yPolicy` constraints (kubernetes-sigs#1218)

* Add handling for node eligibility

* Make tests buildable

* Update topologyspreadconstraint.go

* Updated test cases failing

* squashed changes for test case addition

corrected function name

refactored duplicate TopoContraint check logic

Added more test cases for testing node eligibility scenario

Added 5 test cases for testing scenarios related to node eligibility

* topologySpreadConstraints e2e: `nodeTaintsPolicy` and `nodeAffinityPolicy` constraints

---------

Co-authored-by: Marc Power <marcpow@microsoft.com>
Co-authored-by: nitindagar0 <81955199+nitindagar0@users.noreply.github.com>
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
helm: update cronjob args argument to avoid unmarshal error
…pace-docs

docs: fix evictableNamespaces example
update image references to point to v0.28.0
Pods that don't pass the nodeFit condition currently log an
unsuppressable error message to logs. This changes the log level to info
as it's a normal operating condition.

Signed-off-by: Antoine Deschênes <antoine.deschenes@linux.com>
* Update values.yaml

* Update deployment.yaml

* Update cronjob.yaml

* fix indentation issue in helm chart
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
…itialization

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
topologyspreadconstraint: support `matchLabelKeys`
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2023
@JaneLiuL
Copy link
Member

JaneLiuL commented Nov 3, 2023

thanks @a7i , when you finish an squash the commits please let me know

@a7i
Copy link
Contributor Author

a7i commented Nov 3, 2023

Hi @JaneLiuL we do not squash cherry-picks / release branches

@JaneLiuL
Copy link
Member

JaneLiuL commented Nov 9, 2023

thanks, @a7i , when you finish please let me know~~

@a7i
Copy link
Contributor Author

a7i commented Nov 9, 2023

thanks, @a7i , when you finish please let me know~~

Thanks@JaneLiuL it is ready for review

Copy link
Member

@JaneLiuL JaneLiuL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2023
@knelasevero
Copy link
Contributor

/approve
sorry for long delay!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit e217952 into kubernetes-sigs:release-1.28 Nov 16, 2023
16 checks passed
@a7i a7i deleted the release-1.28.1 branch November 16, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants