Skip to content

Conversation

@dongjiang1989
Copy link
Contributor

fix make verify-gen case

./hack/verify-conversions.sh
Generated output differs:
diff -Naupr pkg/api/v1alpha2/zz_generated.conversion.go ./hack/../_tmp/kube-verify.xQzuB8/descheduler/pkg/api/v1alpha2/zz_generated.conversion.go
--- pkg/api/v1alpha2/zz_generated.conversion.go	2024-01-02 07:52:35.288783826 +0000
+++ ./hack/../_tmp/kube-verify.xQzuB8/descheduler/pkg/api/v1alpha2/zz_generated.conversion.go	2024-01-02 07:57:50.837405635 +0000
@@ -2,7 +2,7 @@
 // +build !ignore_autogenerated
 
 /*
-Copyright 2023 The Kubernetes Authors.
+Copyright 2024 The Kubernetes Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
diff -Naupr pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go ./hack/../_tmp/kube-verify.xQzuB8/descheduler/pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go
--- pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go	2024-01-02 07:52:35.288783826 +0000
+++ ./hack/../_tmp/kube-verify.xQzuB8/descheduler/pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go	2024-01-02 07:57:51.077374503 +0000
@@ -2,7 +2,7 @@
 // +build !ignore_autogenerated
 
 /*
-Copyright 2023 The Kubernetes Authors.
+Copyright 2024 The Kubernetes Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
Generated conversions verify failed. Please run ./hack/update-generated-conversions.sh
make: *** [Makefile:140: verify-gen] Error 1

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2024
@k8s-ci-robot k8s-ci-robot requested review from a7i and lixiang233 January 2, 2024 08:13
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 2, 2024
@dongjiang1989 dongjiang1989 changed the title chores: fix verify-gen check chores(verify-gen): fix verify-gen check Jan 2, 2024
@a7i
Copy link
Contributor

a7i commented Jan 2, 2024

/ok-to-test
/lgtm

thank you!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2024
Copy link
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3cf2c03 into kubernetes-sigs:master Jan 2, 2024
@dongjiang1989 dongjiang1989 deleted the update-verify-gen branch January 3, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants