avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in DefaultEvictor Signed-off-by: Hao Fan <hao.fan@shopee.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @fanhaouu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/cc @ingvagabund |
a7i
approved these changes
Mar 28, 2024
k8s-ci-robot
added
the
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
All good here :) Thx. It looks like a leftover from the migration to plugins. |
spiceratops
referenced
this pull request
in spiceratops/k8s-gitops
May 20, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://togithub.com/xujihui1985) in [https://github.com/kubernetes-sigs/descheduler/pull/1334](https://togithub.com/kubernetes-sigs/descheduler/pull/1334) - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [https://github.com/kubernetes-sigs/descheduler/pull/1330](https://togithub.com/kubernetes-sigs/descheduler/pull/1330) - v1alpha1: log deprecation notice by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1337](https://togithub.com/kubernetes-sigs/descheduler/pull/1337) - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://togithub.com/UAntBou) in [https://github.com/kubernetes-sigs/descheduler/pull/1289](https://togithub.com/kubernetes-sigs/descheduler/pull/1289) - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1343](https://togithub.com/kubernetes-sigs/descheduler/pull/1343) - trim managedFields in shared informer factory by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1346](https://togithub.com/kubernetes-sigs/descheduler/pull/1346) - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1348](https://togithub.com/kubernetes-sigs/descheduler/pull/1348) - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1349](https://togithub.com/kubernetes-sigs/descheduler/pull/1349) - Fix node taint wrong EvictOption field by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1358](https://togithub.com/kubernetes-sigs/descheduler/pull/1358) - Disambiguate node fit log messages by [@​jackfrancis](https://togithub.com/jackfrancis) in [https://github.com/kubernetes-sigs/descheduler/pull/1362](https://togithub.com/kubernetes-sigs/descheduler/pull/1362) - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://togithub.com/nikimanoledaki) in [https://github.com/kubernetes-sigs/descheduler/pull/1356](https://togithub.com/kubernetes-sigs/descheduler/pull/1356) - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://togithub.com/pravarag) in [https://github.com/kubernetes-sigs/descheduler/pull/1359](https://togithub.com/kubernetes-sigs/descheduler/pull/1359) - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1257](https://togithub.com/kubernetes-sigs/descheduler/pull/1257) - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://togithub.com/etoster) in [https://github.com/kubernetes-sigs/descheduler/pull/1360](https://togithub.com/kubernetes-sigs/descheduler/pull/1360) - use v1alpha2 api for helm chart default values by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1139](https://togithub.com/kubernetes-sigs/descheduler/pull/1139) - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://togithub.com/ls-2018) in [https://github.com/kubernetes-sigs/descheduler/pull/1365](https://togithub.com/kubernetes-sigs/descheduler/pull/1365) - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://togithub.com/fanhaouu) in [https://github.com/kubernetes-sigs/descheduler/pull/1369](https://togithub.com/kubernetes-sigs/descheduler/pull/1369) - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1373](https://togithub.com/kubernetes-sigs/descheduler/pull/1373) - Allow eviction of DaemonSet pods by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1342](https://togithub.com/kubernetes-sigs/descheduler/pull/1342) - bump to go 1.22.2 by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1374](https://togithub.com/kubernetes-sigs/descheduler/pull/1374) - helm: Allow the use of existing policy configMap by [@​agmimidi](https://togithub.com/agmimidi) in [https://github.com/kubernetes-sigs/descheduler/pull/1376](https://togithub.com/kubernetes-sigs/descheduler/pull/1376) - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [https://github.com/kubernetes-sigs/descheduler/pull/1379](https://togithub.com/kubernetes-sigs/descheduler/pull/1379) - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [https://github.com/kubernetes-sigs/descheduler/pull/1381](https://togithub.com/kubernetes-sigs/descheduler/pull/1381) - 753 - Descheduling framework by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1372](https://togithub.com/kubernetes-sigs/descheduler/pull/1372) - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1396](https://togithub.com/kubernetes-sigs/descheduler/pull/1396) - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1400](https://togithub.com/kubernetes-sigs/descheduler/pull/1400) #### New Contributors - [@​xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1334](https://togithub.com/kubernetes-sigs/descheduler/pull/1334) - [@​UAntBou](https://togithub.com/UAntBou) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1289](https://togithub.com/kubernetes-sigs/descheduler/pull/1289) - [@​tioxy](https://togithub.com/tioxy) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1349](https://togithub.com/kubernetes-sigs/descheduler/pull/1349) - [@​jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1362](https://togithub.com/kubernetes-sigs/descheduler/pull/1362) - [@​nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1356](https://togithub.com/kubernetes-sigs/descheduler/pull/1356) - [@​etoster](https://togithub.com/etoster) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1360](https://togithub.com/kubernetes-sigs/descheduler/pull/1360) - [@​ls-2018](https://togithub.com/ls-2018) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1365](https://togithub.com/kubernetes-sigs/descheduler/pull/1365) - [@​fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1369](https://togithub.com/kubernetes-sigs/descheduler/pull/1369) - [@​agmimidi](https://togithub.com/agmimidi) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1376](https://togithub.com/kubernetes-sigs/descheduler/pull/1376) - [@​yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1379](https://togithub.com/kubernetes-sigs/descheduler/pull/1379) **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguOSIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
kireque
referenced
this pull request
in kireque/home-ops
May 21, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://togithub.com/xujihui1985) in [https://github.com/kubernetes-sigs/descheduler/pull/1334](https://togithub.com/kubernetes-sigs/descheduler/pull/1334) - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [https://github.com/kubernetes-sigs/descheduler/pull/1330](https://togithub.com/kubernetes-sigs/descheduler/pull/1330) - v1alpha1: log deprecation notice by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1337](https://togithub.com/kubernetes-sigs/descheduler/pull/1337) - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://togithub.com/UAntBou) in [https://github.com/kubernetes-sigs/descheduler/pull/1289](https://togithub.com/kubernetes-sigs/descheduler/pull/1289) - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1343](https://togithub.com/kubernetes-sigs/descheduler/pull/1343) - trim managedFields in shared informer factory by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1346](https://togithub.com/kubernetes-sigs/descheduler/pull/1346) - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1348](https://togithub.com/kubernetes-sigs/descheduler/pull/1348) - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1349](https://togithub.com/kubernetes-sigs/descheduler/pull/1349) - Fix node taint wrong EvictOption field by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1358](https://togithub.com/kubernetes-sigs/descheduler/pull/1358) - Disambiguate node fit log messages by [@​jackfrancis](https://togithub.com/jackfrancis) in [https://github.com/kubernetes-sigs/descheduler/pull/1362](https://togithub.com/kubernetes-sigs/descheduler/pull/1362) - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://togithub.com/nikimanoledaki) in [https://github.com/kubernetes-sigs/descheduler/pull/1356](https://togithub.com/kubernetes-sigs/descheduler/pull/1356) - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://togithub.com/pravarag) in [https://github.com/kubernetes-sigs/descheduler/pull/1359](https://togithub.com/kubernetes-sigs/descheduler/pull/1359) - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1257](https://togithub.com/kubernetes-sigs/descheduler/pull/1257) - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://togithub.com/etoster) in [https://github.com/kubernetes-sigs/descheduler/pull/1360](https://togithub.com/kubernetes-sigs/descheduler/pull/1360) - use v1alpha2 api for helm chart default values by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1139](https://togithub.com/kubernetes-sigs/descheduler/pull/1139) - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://togithub.com/ls-2018) in [https://github.com/kubernetes-sigs/descheduler/pull/1365](https://togithub.com/kubernetes-sigs/descheduler/pull/1365) - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://togithub.com/fanhaouu) in [https://github.com/kubernetes-sigs/descheduler/pull/1369](https://togithub.com/kubernetes-sigs/descheduler/pull/1369) - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1373](https://togithub.com/kubernetes-sigs/descheduler/pull/1373) - Allow eviction of DaemonSet pods by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1342](https://togithub.com/kubernetes-sigs/descheduler/pull/1342) - bump to go 1.22.2 by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1374](https://togithub.com/kubernetes-sigs/descheduler/pull/1374) - helm: Allow the use of existing policy configMap by [@​agmimidi](https://togithub.com/agmimidi) in [https://github.com/kubernetes-sigs/descheduler/pull/1376](https://togithub.com/kubernetes-sigs/descheduler/pull/1376) - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [https://github.com/kubernetes-sigs/descheduler/pull/1379](https://togithub.com/kubernetes-sigs/descheduler/pull/1379) - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [https://github.com/kubernetes-sigs/descheduler/pull/1381](https://togithub.com/kubernetes-sigs/descheduler/pull/1381) - 753 - Descheduling framework by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1372](https://togithub.com/kubernetes-sigs/descheduler/pull/1372) - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1396](https://togithub.com/kubernetes-sigs/descheduler/pull/1396) - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1400](https://togithub.com/kubernetes-sigs/descheduler/pull/1400) #### New Contributors - [@​xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1334](https://togithub.com/kubernetes-sigs/descheduler/pull/1334) - [@​UAntBou](https://togithub.com/UAntBou) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1289](https://togithub.com/kubernetes-sigs/descheduler/pull/1289) - [@​tioxy](https://togithub.com/tioxy) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1349](https://togithub.com/kubernetes-sigs/descheduler/pull/1349) - [@​jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1362](https://togithub.com/kubernetes-sigs/descheduler/pull/1362) - [@​nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1356](https://togithub.com/kubernetes-sigs/descheduler/pull/1356) - [@​etoster](https://togithub.com/etoster) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1360](https://togithub.com/kubernetes-sigs/descheduler/pull/1360) - [@​ls-2018](https://togithub.com/ls-2018) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1365](https://togithub.com/kubernetes-sigs/descheduler/pull/1365) - [@​fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1369](https://togithub.com/kubernetes-sigs/descheduler/pull/1369) - [@​agmimidi](https://togithub.com/agmimidi) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1376](https://togithub.com/kubernetes-sigs/descheduler/pull/1376) - [@​yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1379](https://togithub.com/kubernetes-sigs/descheduler/pull/1379) **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguOSIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
sp3nx0r
referenced
this pull request
in sp3nx0r/homelab
Jun 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://togithub.com/xujihui1985) in [https://github.com/kubernetes-sigs/descheduler/pull/1334](https://togithub.com/kubernetes-sigs/descheduler/pull/1334) - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [https://github.com/kubernetes-sigs/descheduler/pull/1330](https://togithub.com/kubernetes-sigs/descheduler/pull/1330) - v1alpha1: log deprecation notice by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1337](https://togithub.com/kubernetes-sigs/descheduler/pull/1337) - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://togithub.com/UAntBou) in [https://github.com/kubernetes-sigs/descheduler/pull/1289](https://togithub.com/kubernetes-sigs/descheduler/pull/1289) - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1343](https://togithub.com/kubernetes-sigs/descheduler/pull/1343) - trim managedFields in shared informer factory by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1346](https://togithub.com/kubernetes-sigs/descheduler/pull/1346) - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1348](https://togithub.com/kubernetes-sigs/descheduler/pull/1348) - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1349](https://togithub.com/kubernetes-sigs/descheduler/pull/1349) - Fix node taint wrong EvictOption field by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1358](https://togithub.com/kubernetes-sigs/descheduler/pull/1358) - Disambiguate node fit log messages by [@​jackfrancis](https://togithub.com/jackfrancis) in [https://github.com/kubernetes-sigs/descheduler/pull/1362](https://togithub.com/kubernetes-sigs/descheduler/pull/1362) - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://togithub.com/nikimanoledaki) in [https://github.com/kubernetes-sigs/descheduler/pull/1356](https://togithub.com/kubernetes-sigs/descheduler/pull/1356) - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://togithub.com/pravarag) in [https://github.com/kubernetes-sigs/descheduler/pull/1359](https://togithub.com/kubernetes-sigs/descheduler/pull/1359) - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1257](https://togithub.com/kubernetes-sigs/descheduler/pull/1257) - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://togithub.com/etoster) in [https://github.com/kubernetes-sigs/descheduler/pull/1360](https://togithub.com/kubernetes-sigs/descheduler/pull/1360) - use v1alpha2 api for helm chart default values by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1139](https://togithub.com/kubernetes-sigs/descheduler/pull/1139) - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://togithub.com/ls-2018) in [https://github.com/kubernetes-sigs/descheduler/pull/1365](https://togithub.com/kubernetes-sigs/descheduler/pull/1365) - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://togithub.com/fanhaouu) in [https://github.com/kubernetes-sigs/descheduler/pull/1369](https://togithub.com/kubernetes-sigs/descheduler/pull/1369) - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1373](https://togithub.com/kubernetes-sigs/descheduler/pull/1373) - Allow eviction of DaemonSet pods by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1342](https://togithub.com/kubernetes-sigs/descheduler/pull/1342) - bump to go 1.22.2 by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1374](https://togithub.com/kubernetes-sigs/descheduler/pull/1374) - helm: Allow the use of existing policy configMap by [@​agmimidi](https://togithub.com/agmimidi) in [https://github.com/kubernetes-sigs/descheduler/pull/1376](https://togithub.com/kubernetes-sigs/descheduler/pull/1376) - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [https://github.com/kubernetes-sigs/descheduler/pull/1379](https://togithub.com/kubernetes-sigs/descheduler/pull/1379) - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [https://github.com/kubernetes-sigs/descheduler/pull/1381](https://togithub.com/kubernetes-sigs/descheduler/pull/1381) - 753 - Descheduling framework by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1372](https://togithub.com/kubernetes-sigs/descheduler/pull/1372) - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1396](https://togithub.com/kubernetes-sigs/descheduler/pull/1396) - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1400](https://togithub.com/kubernetes-sigs/descheduler/pull/1400) #### New Contributors - [@​xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1334](https://togithub.com/kubernetes-sigs/descheduler/pull/1334) - [@​UAntBou](https://togithub.com/UAntBou) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1289](https://togithub.com/kubernetes-sigs/descheduler/pull/1289) - [@​tioxy](https://togithub.com/tioxy) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1349](https://togithub.com/kubernetes-sigs/descheduler/pull/1349) - [@​jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1362](https://togithub.com/kubernetes-sigs/descheduler/pull/1362) - [@​nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1356](https://togithub.com/kubernetes-sigs/descheduler/pull/1356) - [@​etoster](https://togithub.com/etoster) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1360](https://togithub.com/kubernetes-sigs/descheduler/pull/1360) - [@​ls-2018](https://togithub.com/ls-2018) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1365](https://togithub.com/kubernetes-sigs/descheduler/pull/1365) - [@​fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1369](https://togithub.com/kubernetes-sigs/descheduler/pull/1369) - [@​agmimidi](https://togithub.com/agmimidi) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1376](https://togithub.com/kubernetes-sigs/descheduler/pull/1376) - [@​yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1379](https://togithub.com/kubernetes-sigs/descheduler/pull/1379) **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sp3nx0r/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zODguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvbWlub3IiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in teutonet/teutonet-helm-charts
Jul 4, 2024
…0.30.x (#1015) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.x` -> `0.30.x` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.1): Descheduler v0.30.1 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) #### What's Changed - bump to to 1.22.3 to address CVE-2024-24788 by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1408](https://togithub.com/kubernetes-sigs/descheduler/pull/1408) - \[release 1.30] update kustomize image tags and helm versions by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1405](https://togithub.com/kubernetes-sigs/descheduler/pull/1405) - Automated cherry pick of [#​1378](https://togithub.com/kubernetes-sigs/descheduler/issues/1378): Fix the replicas type for the helm-chart [#​1390](https://togithub.com/kubernetes-sigs/descheduler/issues/1390): allow 'falsey' value in cmdOption [#​1412](https://togithub.com/kubernetes-sigs/descheduler/issues/1412): fix helm's default deschedulerPolicy [#​1413](https://togithub.com/kubernetes-sigs/descheduler/issues/1413): fix TOC location in Readme [#​1416](https://togithub.com/kubernetes-sigs/descheduler/issues/1416): use cmd context instead of using context.Background() [#​1395](https://togithub.com/kubernetes-sigs/descheduler/issues/1395): fix the issue that the pod anti-filtering rules are not by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1425](https://togithub.com/kubernetes-sigs/descheduler/pull/1425) **Full Changelog**: kubernetes-sigs/descheduler@v0.30.0...v0.30.1 ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://togithub.com/xujihui1985) in [https://github.com/kubernetes-sigs/descheduler/pull/1334](https://togithub.com/kubernetes-sigs/descheduler/pull/1334) - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [https://github.com/kubernetes-sigs/descheduler/pull/1330](https://togithub.com/kubernetes-sigs/descheduler/pull/1330) - v1alpha1: log deprecation notice by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1337](https://togithub.com/kubernetes-sigs/descheduler/pull/1337) - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://togithub.com/UAntBou) in [https://github.com/kubernetes-sigs/descheduler/pull/1289](https://togithub.com/kubernetes-sigs/descheduler/pull/1289) - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1343](https://togithub.com/kubernetes-sigs/descheduler/pull/1343) - trim managedFields in shared informer factory by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1346](https://togithub.com/kubernetes-sigs/descheduler/pull/1346) - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1348](https://togithub.com/kubernetes-sigs/descheduler/pull/1348) - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1349](https://togithub.com/kubernetes-sigs/descheduler/pull/1349) - Fix node taint wrong EvictOption field by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1358](https://togithub.com/kubernetes-sigs/descheduler/pull/1358) - Disambiguate node fit log messages by [@​jackfrancis](https://togithub.com/jackfrancis) in [https://github.com/kubernetes-sigs/descheduler/pull/1362](https://togithub.com/kubernetes-sigs/descheduler/pull/1362) - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://togithub.com/nikimanoledaki) in [https://github.com/kubernetes-sigs/descheduler/pull/1356](https://togithub.com/kubernetes-sigs/descheduler/pull/1356) - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://togithub.com/pravarag) in [https://github.com/kubernetes-sigs/descheduler/pull/1359](https://togithub.com/kubernetes-sigs/descheduler/pull/1359) - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1257](https://togithub.com/kubernetes-sigs/descheduler/pull/1257) - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://togithub.com/etoster) in [https://github.com/kubernetes-sigs/descheduler/pull/1360](https://togithub.com/kubernetes-sigs/descheduler/pull/1360) - use v1alpha2 api for helm chart default values by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1139](https://togithub.com/kubernetes-sigs/descheduler/pull/1139) - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://togithub.com/ls-2018) in [https://github.com/kubernetes-sigs/descheduler/pull/1365](https://togithub.com/kubernetes-sigs/descheduler/pull/1365) - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://togithub.com/fanhaouu) in [https://github.com/kubernetes-sigs/descheduler/pull/1369](https://togithub.com/kubernetes-sigs/descheduler/pull/1369) - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1373](https://togithub.com/kubernetes-sigs/descheduler/pull/1373) - Allow eviction of DaemonSet pods by [@​tioxy](https://togithub.com/tioxy) in [https://github.com/kubernetes-sigs/descheduler/pull/1342](https://togithub.com/kubernetes-sigs/descheduler/pull/1342) - bump to go 1.22.2 by [@​jklaw90](https://togithub.com/jklaw90) in [https://github.com/kubernetes-sigs/descheduler/pull/1374](https://togithub.com/kubernetes-sigs/descheduler/pull/1374) - helm: Allow the use of existing policy configMap by [@​agmimidi](https://togithub.com/agmimidi) in [https://github.com/kubernetes-sigs/descheduler/pull/1376](https://togithub.com/kubernetes-sigs/descheduler/pull/1376) - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [https://github.com/kubernetes-sigs/descheduler/pull/1379](https://togithub.com/kubernetes-sigs/descheduler/pull/1379) - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [https://github.com/kubernetes-sigs/descheduler/pull/1381](https://togithub.com/kubernetes-sigs/descheduler/pull/1381) - 753 - Descheduling framework by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1372](https://togithub.com/kubernetes-sigs/descheduler/pull/1372) - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://togithub.com/ingvagabund) in [https://github.com/kubernetes-sigs/descheduler/pull/1396](https://togithub.com/kubernetes-sigs/descheduler/pull/1396) - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://togithub.com/a7i) in [https://github.com/kubernetes-sigs/descheduler/pull/1400](https://togithub.com/kubernetes-sigs/descheduler/pull/1400) #### New Contributors - [@​xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1334](https://togithub.com/kubernetes-sigs/descheduler/pull/1334) - [@​UAntBou](https://togithub.com/UAntBou) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1289](https://togithub.com/kubernetes-sigs/descheduler/pull/1289) - [@​tioxy](https://togithub.com/tioxy) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1349](https://togithub.com/kubernetes-sigs/descheduler/pull/1349) - [@​jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1362](https://togithub.com/kubernetes-sigs/descheduler/pull/1362) - [@​nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1356](https://togithub.com/kubernetes-sigs/descheduler/pull/1356) - [@​etoster](https://togithub.com/etoster) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1360](https://togithub.com/kubernetes-sigs/descheduler/pull/1360) - [@​ls-2018](https://togithub.com/ls-2018) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1365](https://togithub.com/kubernetes-sigs/descheduler/pull/1365) - [@​fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1369](https://togithub.com/kubernetes-sigs/descheduler/pull/1369) - [@​agmimidi](https://togithub.com/agmimidi) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1376](https://togithub.com/kubernetes-sigs/descheduler/pull/1376) - [@​yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [https://github.com/kubernetes-sigs/descheduler/pull/1379](https://togithub.com/kubernetes-sigs/descheduler/pull/1379) **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/teutonet/teutonet-helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the DefaultEvictorArgs parameters undergo redundant type conversion in DefaultEvictor, which is unnecessary.
This pr can resolve that.