[e2e] abstract common methods

[fanhaouu]

abstract and aggregate some common methods in E2E tests to avoid redundancy.

[k8s-ci-robot]

Hi @fanhaouu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fanhaouu]

@ingvagabund Hi, master, this is the second of the splited PRs. Need your ok-to-test.

[a7i]

/ok-to-test

great change 🏆

[fanhaouu]

/ok-to-test

great change 🏆

thank you, master

[ingvagabund]

Few nits. The rest looks good. Thank you :)

[ingvagabund]

/retest-required

[fanhaouu]

/test pull-descheduler-verify-master

[fanhaouu]

@ingvagabund hi, master, thank you for your careful and patient review. All the test cases have been passed.

[fanhaouu]

@a7i @ingvagabund Hi, master, how can I apply for the ok-to-test permission? I have quite a few MRs coming up, and I hope to have that permission.

[ingvagabund]

how can I apply for the ok-to-test permission?

Hey @fanhaouu :) You need to be a member of kubernetes-sigs organization.

[ingvagabund]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ingvagabund]

Hello @fanhaouu. There's a list of requirements that needs to be meet: https://github.com/kubernetes/community/blob/master/community-membership.md#requirements. Every project may adjust the set of requirements for becoming a member. Some projects with low traffic do not allow to produce and review many PRs so we need to compensate. I see you have 6 merged PRs already at https://github.com/kubernetes-sigs/descheduler/pulls?q=is%3Apr+author%3Afanhaouu+is%3Aclosed. I'd like to see some technical reviews produced as well. Unless you have already done these :). Links to these PRs will be much appreciated. Other than that I am happy to sponsor you.

[fanhaouu]

Hello @fanhaouu. There's a list of requirements that needs to be meet: https://github.com/kubernetes/community/blob/master/community-membership.md#requirements. Every project may adjust the set of requirements for becoming a member. Some projects with low traffic do not allow to produce and review many PRs so we need to compensate. I see you have 6 merged PRs already at https://github.com/kubernetes-sigs/descheduler/pulls?q=is%3Apr+author%3Afanhaouu+is%3Aclosed. I'd like to see some technical reviews produced as well. Unless you have already done these :). Links to these PRs will be much appreciated. Other than that I am happy to sponsor you.

like this?review PR?
#1366
#1092 (comment)

[ingvagabund]

@fanhaouu that's a good start. PR reviews from both orgs (kubernetes, kubernetes-sigs) counts as well. If there are other projects you can refer to.

[fanhaouu]

@fanhaouu that's a good start. PR reviews from both orgs (kubernetes, kubernetes-sigs) counts as well. If there are other projects you can refer to.

kubernetes/kubernetes#120661 (comment)

[fanhaouu]

haha, I don't even have permission to do ok-to-test, so I rarely review k8s/k8s sig code.

[ingvagabund]

I could use review help with #1466.

[fanhaouu]

Please ignore my previous rash and unreasonable request; I have deleted it and I apologize for that. @a7i @ingvagabund

[ingvagabund]

No worries :) This week was kinda wild. I had to focus on different areas. I am slowly getting back to resume reviews and other activities in the project :) Thank you for the other review. I will take a look at it.

[ingvagabund]

@fanhaouu feel free to ask for the membership. I will sponsor you. Thanks for keeping up the good work.

[fanhaouu]

@fanhaouu feel free to ask for the membership. I will sponsor you. Thanks for keeping up the good work.

thank you, master