Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run e2e Tests Against Multiple k8s Versions #222

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Run e2e Tests Against Multiple k8s Versions #222

merged 1 commit into from
Feb 12, 2020

Conversation

seanmalloy
Copy link
Member

@seanmalloy seanmalloy commented Jan 30, 2020 •
edited
Loading

Enable a build matrix in Travis CI to run the e2e tests against multiple k8s versions. Additionally update kind to v0.7.0 which adds support for k8s v1.17.

Replaced command "kind get kubeconfig-path" with "kind get kubeconfig" because the "kubeconfig-path" subcommand is not valid with kind v0.7.0.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2020
@seanmalloy seanmalloy force-pushed the travis-build-matrix branch 2 times, most recently from 97412b5 to 2d2b742 Compare January 30, 2020 07:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2020
@seanmalloy
Copy link
Member Author

Check out this cool screen shot that shows the new test matrix in Travis CI. The e2e tests pass when run against k8s v1.17, v1.16, and v1.15.

Screen Shot 2020-01-30 at 1 30 06 AM

@seanmalloy
Copy link
Member Author

/assign @aveshagarwal
/cc @damemi @ravisantoshgudimetla

@seanmalloy
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 8, 2020
@seanmalloy
Run e2e Tests Against Multiple k8s Versions
7d93551 
Enable a build matrix in Travis CI to run the e2e tests against
multiple k8s versions. Additionally update kind to v0.7.0 which adds
support for k8s v1.17.

Replaced command "kind get kubeconfig-path" with "kind get kubeconfig"
because the "kubeconfig-path" subcommand is not valid with kind v0.7.0.
@seanmalloy
Copy link
Member Author

@damemi @aveshagarwal @ravisantoshgudimetla please review when you have some time. I believe it will be useful to have the e2e tests run against multiple k8s versions.

@ingvagabund
Copy link
Contributor

Increase test coverage is never a bad thing to do as long as the resources are available.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2020
@aveshagarwal
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7a6e095 into kubernetes-sigs:master Feb 12, 2020
@seanmalloy seanmalloy deleted the travis-build-matrix branch June 22, 2020 16:34
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#222 from KohlsTechnology/travis-bu…
885ae79 
…ild-matrix

Run e2e Tests Against Multiple k8s Versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

@damemi damemi Awaiting requested review from damemi

@ravisantoshgudimetla ravisantoshgudimetla Awaiting requested review from ravisantoshgudimetla

Assignees

@aveshagarwal aveshagarwal

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanmalloy @ingvagabund @aveshagarwal @k8s-ci-robot