-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List nodes through informer in every iteration #249
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:master
from
ingvagabund:list-node-through-informer-in-every-iteration
Mar 4, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package descheduler | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/util/wait" | ||
| fakeclientset "k8s.io/client-go/kubernetes/fake" | ||
| "sigs.k8s.io/descheduler/cmd/descheduler/app/options" | ||
| "sigs.k8s.io/descheduler/pkg/api" | ||
| "sigs.k8s.io/descheduler/test" | ||
| ) | ||
|
|
||
| func TestTaintsUpdated(t *testing.T) { | ||
| n1 := test.BuildTestNode("n1", 2000, 3000, 10) | ||
| n2 := test.BuildTestNode("n2", 2000, 3000, 10) | ||
|
|
||
| p1 := test.BuildTestPod(fmt.Sprintf("pod_1_%s", n1.Name), 200, 0, n1.Name) | ||
| p1.ObjectMeta.OwnerReferences = []metav1.OwnerReference{ | ||
| {}, | ||
| } | ||
|
|
||
| client := fakeclientset.NewSimpleClientset(n1, n2, p1) | ||
| dp := &api.DeschedulerPolicy{ | ||
| Strategies: api.StrategyList{ | ||
| "RemovePodsViolatingNodeTaints": api.DeschedulerStrategy{ | ||
| Enabled: true, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| stopChannel := make(chan struct{}) | ||
| defer close(stopChannel) | ||
|
|
||
| rs := options.NewDeschedulerServer() | ||
| rs.Client = client | ||
| rs.DeschedulingInterval = 100 * time.Millisecond | ||
| go func() { | ||
| err := RunDeschedulerStrategies(rs, dp, "v1beta1", stopChannel) | ||
| if err != nil { | ||
| t.Fatalf("Unable to run descheduler strategies: %v", err) | ||
| } | ||
| }() | ||
|
|
||
| // Wait for few cycles and then verify the only pod still exists | ||
| time.Sleep(300 * time.Millisecond) | ||
| pods, err := client.CoreV1().Pods(p1.Namespace).List(metav1.ListOptions{}) | ||
| if err != nil { | ||
| t.Errorf("Unable to list pods: %v", err) | ||
| } | ||
| if len(pods.Items) < 1 { | ||
| t.Errorf("The pod was evicted before a node was tained") | ||
| } | ||
|
|
||
| n1WithTaint := n1.DeepCopy() | ||
| n1WithTaint.Spec.Taints = []v1.Taint{ | ||
| { | ||
| Key: "key", | ||
| Value: "value", | ||
| Effect: v1.TaintEffectNoSchedule, | ||
| }, | ||
| } | ||
|
|
||
| if _, err := client.CoreV1().Nodes().Update(n1WithTaint); err != nil { | ||
| t.Fatalf("Unable to update node: %v\n", err) | ||
| } | ||
|
|
||
| if err := wait.PollImmediate(100*time.Millisecond, time.Second, func() (bool, error) { | ||
| // Get over evicted pod result in panic | ||
| //pods, err := client.CoreV1().Pods(p1.Namespace).Get(p1.Name, metav1.GetOptions{}) | ||
| // List is better, it does not panic. | ||
| // Though once the pod is evicted, List starts to error with "can't assign or convert v1beta1.Eviction into v1.Pod" | ||
| pods, err := client.CoreV1().Pods(p1.Namespace).List(metav1.ListOptions{}) | ||
| if err == nil { | ||
| if len(pods.Items) > 0 { | ||
| return false, nil | ||
| } | ||
| return true, nil | ||
| } | ||
| if strings.Contains(err.Error(), "can't assign or convert v1beta1.Eviction into v1.Pod") { | ||
| return true, nil | ||
| } | ||
|
|
||
| return false, nil | ||
| }); err != nil { | ||
| t.Fatalf("Unable to evict pod, node taint did not get propagated to descheduler strategies") | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is number this a good candidate for a configurable option in a future PR? e.g. a user might want to set this to match the number of AZs in their cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nodes is a minimal condition for running the descheduler. In case you need to also verify each AZ has at list one node available, what are the chances you will not have it before you run the descheduler. Also, it's maybe more convenient for individual strategies. No strategy should evict a pod if there's no other node where the new pod can land. Including constraining strategies to be zone aware.