Fix early return from PodFitsAnyNode check #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/priority critical-urgent |
k8s-ci-robot
added
priority/critical-urgent
ingvagabund
reviewed
Apr 2, 2020
| @@ -115,7 +115,6 @@ func PodFitsAnyNode(pod *v1.Pod, nodes []*v1.Node) bool { | |||
| klog.V(2).Infof("Pod %v can possibly be scheduled on %v", pod.Name, node.Name) | |||
| return true | |||
| } | |||
| return false | |||
There was a problem hiding this comment.
You can drop entire if ok block, ok has to be true at this point.
damemi
force-pushed
the
fix-podfitsanynode
branch
from
0713da7
to
9b7891b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
damemi
force-pushed
the
fix-podfitsanynode
branch
from
9b7891b
to
e95e429
Compare
k8s-ci-robot
added
size/M
ravisantoshgudimetla
approved these changes
Apr 7, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
Fix early return from PodFitsAnyNode check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PodFitsAnyNodefunction returnedfalseearly if it hit any node with matched the selectors but was also unschedulable (before finding a suitable node).This PR also includes vendor updates that weren't committed earlier, in order to compile.