Remove redundant eviction log message and add "Reason" param to EvictPod #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the changes in #287, because the PodEvictor logs when a pod is successfully evicted (either in dry-run or normal mode) this message becomes redundant and confusing when in dry run. For example, it currently looks like:
This extra message doesn't provide much information, though it may be reasonable to add an extra "reason" parameter to
podEvictor.EvictPod
to give context on what strategy specifically caused the eviction (since all eviction logs now just originate fromevictions.go
). This includes that change and the log output looks like: