Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid appending list multiple times in RemoveDuplicates #336

Merged
merged 1 commit into from
Jul 9, 2020
Merged

avoid appending list multiple times in RemoveDuplicates #336

merged 1 commit into from
Jul 9, 2020

Conversation

lixiang233
Copy link
Contributor

Currently, appending podContainerKeys to duplicateKeysMap[podContainerKeys[0]] is inside the for loop, so it may append same keys multiple times.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @lixiang233. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2020
@lixiang233
Copy link
Contributor Author

/kind bug
/cc @damemi @seanmalloy

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 7, 2020
@ingvagabund
Copy link
Contributor

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 7, 2020
ingvagabund
ingvagabund reviewed Jul 7, 2020
View reviewed changes
pkg/descheduler/strategies/duplicates.go
duplicatePods = append(duplicatePods, pod)
break
}
}
if !matched {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a bug. Even though the list of keys is duplicated, it will never get read since if reflect.DeepEqual(keys, podContainerKeys) { has break keyword so the duplicated lists are never checked against.

The code change avoids duplication. Which will have almost zero impact on the performance unless the list of pods is quite large and there's many duplicates. I will leave this for @damemi to decide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change improves the performance obviously only in some extreme situations which may never happen in real world.

I think the original design was: append podContainerKeys to the list only one time if there's no same keys in it, but the implementation has defect that will cause this operation happens multiple times, so I treat this as a bug.

@ingvagabund
Copy link
Contributor

/kind bug cancel

@k8s-ci-robot
Copy link
Contributor

@ingvagabund: The label(s) kind/cancel cannot be applied, because the repository doesn't have them

In response to this:

/kind bug cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Contributor

/kind cancel bug

@k8s-ci-robot
Copy link
Contributor

@ingvagabund: The label(s) kind/cancel cannot be applied, because the repository doesn't have them

In response to this:

/kind cancel bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Contributor

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Jul 7, 2020
@seanmalloy
Copy link
Member

/assign @damemi

damemi
damemi approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me, good catch on this @lixiang233 thanks!
/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, lixiang233

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 05c69ee into kubernetes-sigs:master Jul 9, 2020
@lixiang233 lixiang233 deleted the avoid_duplicated_append_RemoveDuplicatePods branch July 9, 2020 08:58
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#336 from lixiang233/avoid_duplicat…
ff91a2a 
…ed_append_RemoveDuplicatePods

avoid appending list multiple times in RemoveDuplicates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@damemi damemi damemi approved these changes

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@damemi damemi

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lixiang233 @k8s-ci-robot @ingvagabund @seanmalloy @damemi