Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick: Add helm chart release-1.18 #352

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Cherry Pick: Add helm chart release-1.18 #352

merged 3 commits into from
Jul 21, 2020

Conversation

seanmalloy
Copy link
Member

@seanmalloy seanmalloy commented Jul 17, 2020 •
edited
Loading

Cherry pick the below commits from the master branch:

  • 4507a90 - initial helm chart
  • c7692a2 - release docs for helm charts
  • ca8f105 - change helm chart version to 0.18.0

After this is merged the proposed release process in #351 could be executed to release to first official descheduler helm chart.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2020
@seanmalloy
Copy link
Member Author

/assign @damemi @ingvagabund

FYI ... @stevehipwell I'm cherry picking the descheduler helm chart to the release-1.18 branch. Let me know if you see any problems with this. Thanks!

@seanmalloy seanmalloy mentioned this pull request Jul 17, 2020
Closed
@seanmalloy seanmalloy changed the title Cherry Pick: Add helm chart Cherry Pick: Add helm chart release-1.18 Jul 17, 2020
@seanmalloy
Copy link
Member Author

/hold

Waiting to finalize helm chart versioning and release process in #351. This PR will be updated after #351 is merged to the master branch.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2020
damemi
damemi approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
So once we have this, we could do a test run of releasing by pushing to chart-0.18.0 right?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@seanmalloy
Copy link
Member Author

So once we have this, we could do a test run of releasing by pushing to chart-0.18.0 right?

Yes, that is correct.

@seanmalloy
Update Release Documentation For Helm Charts
60e4167 
The descheduler now has an official helm chart. This change documents the
process to release a new helm chart artifact.
@seanmalloy
Update Helm Chart Version To 0.18.0
870a518
@seanmalloy
Copy link
Member Author

@ingvagabund and @lixiang233 please review when you have some time. The PR back ports all of the helm chart changes from the master branch to the release-1.18 branch. After this is merged we can attempt the first official descheduler helm chart release.

@lixiang233
Copy link
Contributor

/lgtm
good to go as all these commits have already been merged into master branch.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@seanmalloy
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit f959101 into kubernetes-sigs:release-1.18 Jul 21, 2020
@seanmalloy seanmalloy deleted the helm-chart-release-1.18 branch July 21, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@damemi damemi

@ingvagabund ingvagabund

@lixiang233 lixiang233

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seanmalloy @k8s-ci-robot @lixiang233 @damemi @ingvagabund @stevehipwell