Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodLifeTime: allow custom podStatusPhases #393

Merged
merged 1 commit into from
Sep 11, 2020
Merged

PodLifeTime: allow custom podStatusPhases #393

merged 1 commit into from
Sep 11, 2020

Conversation

lixiang233
Copy link
Contributor

fixes: #62

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2020
@lixiang233 lixiang233 force-pushed the Ft_custom_pod_phase_PodLifeTime branch from 6831e04 to 91e9002 Compare September 3, 2020 09:26
@damemi damemi mentioned this pull request Sep 3, 2020
Closed
@seanmalloy
Copy link
Member

/cc

@seanmalloy
Copy link
Member

/assign

@seanmalloy
Copy link
Member

Nice work @lixiang233!

/lgtm
/kind feature
/assign @damemi
/cc @ingvagabund

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 4, 2020
ingvagabund
ingvagabund reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@ingvagabund ingvagabund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit. Lgtm otherwise.

pkg/descheduler/strategies/pod_lifetime.go Outdated Show resolved Hide resolved
@lixiang233 lixiang233 force-pushed the Ft_custom_pod_phase_PodLifeTime branch from 91e9002 to 0624c3a Compare September 10, 2020 01:34
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2020
@lixiang233
Copy link
Contributor Author

fixed, PTAL @ingvagabund @seanmalloy

@seanmalloy
Copy link
Member

@damemi please take a look when have some time. Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2020
@ingvagabund
Copy link
Contributor

/lgtm

damemi
damemi reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit on the example but I won't block on it
/approve
/hold
feel free to remove the hold if you disagree with my change

README.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, lixiang233

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@lixiang233 lixiang233 force-pushed the Ft_custom_pod_phase_PodLifeTime branch from 0624c3a to 1303fe6 Compare September 11, 2020 02:00
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@lixiang233
Copy link
Contributor Author

updated README, PTAL @damemi @seanmalloy @ingvagabund

@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@ingvagabund
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit d25f375 into kubernetes-sigs:master Sep 11, 2020
@lixiang233 lixiang233 deleted the Ft_custom_pod_phase_PodLifeTime branch September 15, 2020 06:45
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#393 from lixiang233/Ft_custom_pod_…
bf5b5a9 
…phase_PodLifeTime

PodLifeTime: allow custom podStatusPhases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@ingvagabund ingvagabund ingvagabund left review comments

@seanmalloy seanmalloy seanmalloy approved these changes

Assignees

@seanmalloy seanmalloy

@damemi damemi

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deschedule pods that fail to start or restart too often
5 participants
@lixiang233 @seanmalloy @ingvagabund @k8s-ci-robot @damemi