Update Helm Chart To Allow Setting startingDeadlineSeconds #444
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/kind feature @stevehipwell here is another small helm chart tweak. Please review if you have time. Thanks! |
k8s-ci-robot
added
the
kind/feature
There was a problem hiding this comment.
@seanmalloy I've added a couple of review comments for you.
| @@ -7,6 +7,9 @@ metadata: | |||
| spec: | |||
| schedule: {{ .Values.schedule | quote }} | |||
| concurrencyPolicy: "Forbid" | |||
| {{- if .Values.priorityClassName }} | |||
There was a problem hiding this comment.
I think this should probably be {{- if .Values.startingDeadlineSeconds }}
There was a problem hiding this comment.
Correct. I amended the commit to fix this
Allow end users to optionally set the descheduler CronJob .spec.startingDeadlineSeconds when installing using helm.
seanmalloy
force-pushed
the
issue-432-cronjob
branch
from
5d92b60
to
03852d0
Compare
|
@stevehipwell I fixed the two problems you found. Thanks! |
|
@seanmalloy do you know when the chart re-releases with the correct name will happen? |
@stevehipwell probably just prior to or as part of the descheduler v0.20.0 release. Should be in December shortly after the k8s v1.20 release. |
|
@damemi and @ingvagabund this one is ready for you to review now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…-cronjob Update Helm Chart To Allow Setting startingDeadlineSeconds
Allow end users to optionally set the descheduler CronJob
.spec.startingDeadlineSeconds when installing using helm.
Fixes #432