Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting options successfulJobsHistoryLimit and failedJobsHistoryLimit for cronjob #453

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Allow setting options successfulJobsHistoryLimit and failedJobsHistoryLimit for cronjob #453

merged 1 commit into from
Dec 8, 2020

Conversation

dieterdemeyer
Copy link
Contributor

Allow end users to optionally set the descheduler CronJob .spec.successfulJobsHistoryLimit and .spec.failedJobsHistoryLimit when installing using helm chart.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @dieterdemeyer!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dieterdemeyer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 3, 2020
@dieterdemeyer
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 3, 2020
@dieterdemeyer
Copy link
Contributor Author

/assign @k82cn

ingvagabund
ingvagabund reviewed Dec 3, 2020
View reviewed changes
charts/descheduler/Chart.yaml
version: 0.19.0
appVersion: 0.19.0
version: 0.20.0
appVersion: 0.20.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

descheduler 1.20 is not out yet, do you expect the PR to be merge after 1.20 is released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping that this could be merged and released in version 0.20.0.
Should I not have modified this file ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still doable. It just feels strange to merge anything with 0.20 before the descheduler image for the release is published. I was just making sure :) No blocker here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, I can revert the file to be more in line with other pull requests. It's a quick change..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will defer this to @damemi and @seanmalloy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the master branch correlates to the upcoming release, so this is a change we'll have to make anyway before the release. I don't see a problem making that change now if @seanmalloy doesn't either

damemi
damemi reviewed Dec 3, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I'm fine with the changes here if it looks good to everyone else

charts/descheduler/Chart.yaml
version: 0.19.0
appVersion: 0.19.0
version: 0.20.0
appVersion: 0.20.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically the master branch correlates to the upcoming release, so this is a change we'll have to make anyway before the release. I don't see a problem making that change now if @seanmalloy doesn't either

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@damemi
Copy link
Contributor

damemi commented Dec 8, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2020
@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, dieterdemeyer, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5091185 into kubernetes-sigs:master Dec 8, 2020
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#453 from dieterdemeyer/master
bc9a8c4 
Allow setting options successfulJobsHistoryLimit and failedJobsHistoryLimit for cronjob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@damemi damemi damemi left review comments

@seanmalloy seanmalloy seanmalloy approved these changes

Assignees

@seanmalloy seanmalloy

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dieterdemeyer @k8s-ci-robot @damemi @seanmalloy @ingvagabund @k82cn